help with syntax in array

[dflow]

i have this array, i want to change the link phrase with a variable

i get his error:

Parse error: syntax error, unexpected T_VARIABLE, expecting ')' in city.php on line 58

this is line 58,59

$with=array("<a href='index.html'>index</a>", "<a href='index.html'>$xmlcitydata->data->city</a>");

 

 

[gristoi]

you will find that errors of this nature are not usually on the line in question. what is on the lines preceding this one?

[redixx]

Concatenating seemed to work for me.

 

$with=array("<a href='index.html'>index</a>", "<a href='index.html'>" . $xmlcitydata->data->city . "</a>");

 

If not, then this isn't the line with the error.

[mikesta707]

judging from the error, you are missing a closing parenthesis on the line(s) above

[dflow]

Concatenating seemed to work for me.

 

$with=array("<a href='index.html'>index</a>", "<a href='index.html'>" . $xmlcitydata->data->city . "</a>");

 

If not, then this isn't the line with the error.

 

excellent did the job thank you all

[dflow]

i have a new problem with this when adding extra $vars

this works:

$with=array("<a href='index.html'>index</a>", "<a href='".$xmlcitydata->data->main_backlink_rt_1 .'/'.$xmlcitydata->data->city_name."'.html'>".$xmlcitydata->data->city_kw_1_rt_1."</a>");

 

and i wan this to work as well

$with=array("<a href='index.html'>index</a>", "<a href='".$xmlcitydata->data->main_backlink_rt_1 .'/'.$xmlcitydata->data->city_name."'.html'>".$xmlcitydata->data->city_kw_1_rt_1.$xmlcitydata->data->city_name"</a>");

error received:

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')'

error is for adding this .$xmlcitydata->data->city_name

[cyberRobot]

Looks like you're missing a dot near the end. This:

 

city_kw_1_rt_1.$xmlcitydata->data->city_name"</a>");

 

Should be:

 

city_kw_1_rt_1.$xmlcitydata->data->city_name."</a>");

[redixx]

In the interest of readable code, I would suggest to you that you add spaces around concatenation to help you see where variables separate from the string. Whitespace won't be parsed so it won't cause any errors.

 

// instead of
echo 'blahblah'.$variable.'blahblahblah'.$variable2;

// do
echo 'blahblah' . $variable . 'blahblahblah' . $variable2;

[kenrbnsn]

A more readable version would be to use "{ }" around the variables:

<?php
$with=array("<a href='index.html'>index</a>", "<a href='{$xmlcitydata->data->main_backlink_rt_1}/{$xmlcitydata->data->city_name}.html'>{$xmlcitydata->data->city_kw_1_rt_1}</a>");
?>

 

Ken

[dflow]

A more readable version would be to use "{ }" around the variables:

<?php
$with=array("<a href='index.html'>index</a>", "<a href='{$xmlcitydata->data->main_backlink_rt_1}/{$xmlcitydata->data->city_name}.html'>{$xmlcitydata->data->city_kw_1_rt_1}</a>");
?>

 

great this just solved another problem thanks!

 

Ken