michaelburt Posted October 7, 2011 Share Posted October 7, 2011 Hi there guys. I joined the forum a little while ago and I was wondering if you could check my site out! I'm a website designer (been designing for 6+ years now) and a full time university student. So it's really not my day job, but more of a hobby. http://www.michaelburtdesigns.com Please critique! Thanks Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/ Share on other sites More sharing options...
doddsey_65 Posted October 7, 2011 Share Posted October 7, 2011 To be honest if you have been doing this for 6+ years, as you said, I would expect more. You haven't included a valid Doctype, you have failed to provide the character encoding. None of your img tags have alt attributes, which are required and the div with class "inner10" could use some padding on the bottom. Im not a fan on how you've used the colors either but that's just personal preference. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276714 Share on other sites More sharing options...
AyKay47 Posted October 7, 2011 Share Posted October 7, 2011 To be honest if you have been doing this for 6+ years, as you said, I would expect more. You haven't included a valid Doctype, you have failed to provide the character encoding. None of your img tags have alt attributes, which are required and the div with class "inner10" could use some padding on the bottom. Im not a fan on how you've used the colors either but that's just personal preference. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276741 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 1) For me the doctype is an obscurity- I used a text-spacing attribute for a special look for my font, which a transitional Doctype dis-renders 2) Declaring the encoding type is redundant if I'm not declaring the doctype. It's default for browsers nowadays I appreciate your critique, but I have thought about the points you mentioned. I understand the point of a doctype for validity purposes, but it is merely an abstraction for me, because personally, I like the spacing of the text. But like I said, thanks, I appreciate your insight! Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276941 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 Also when I said "6 years" I meant what I said- I'm only 18 years old and I started when I was 12. From the ages of around 12-16 I did little to nothing in the way of actually designing other people's websites, and I only started "michaelburtdesigns.com" in the last 2 months. I've had many inquiries, and a total of 5 clients (2 underway). So I can understand that saying I've been doing this for 6 years looks bad, but it's really not. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276944 Share on other sites More sharing options...
AyKay47 Posted October 7, 2011 Share Posted October 7, 2011 bottom line, needs restyled Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276946 Share on other sites More sharing options...
ZulfadlyAshBurn Posted October 7, 2011 Share Posted October 7, 2011 The news updates goes to the below the content box if the user's screen resolution is lower than your actual site. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276951 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 The news thing I actually do have to fix. It happens because the main panel and news panel are at fixed width values and aren't in a parent container of a fixed width value. When I get time to fix this I certainly will. Speaking of restyling... I have been thinking about it for about a week now but I haven't really had the time to seriously making a go at doing it. But I will post an update here if I do. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276957 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 I just fixed the main panel/news stacking issue. I'm thinking now that having the whole portion of the webpage almost 1100px wide is too much. Maybe 900px would be a bit more standard. What do you guys think? Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276960 Share on other sites More sharing options...
ZulfadlyAshBurn Posted October 7, 2011 Share Posted October 7, 2011 what i would actually do is to set the main panel to 80% and the news feed to 20% Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276963 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 Can't use percentages because that would distort the background images. That being said, I do understand how accessible percentages are, but they won't really conform to the graphics I've made. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276964 Share on other sites More sharing options...
AyKay47 Posted October 7, 2011 Share Posted October 7, 2011 parent divs should be set to a defined width.. child divs can have percentage widths Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276965 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 I don't think you really understand the layout of my website, because the main content area panel has a different background than the news panel area. You can't change the parent container width or the child width (what's the point, the child width is 100%?), because like I said, it would distort the images. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276968 Share on other sites More sharing options...
AyKay47 Posted October 7, 2011 Share Posted October 7, 2011 of course I understand the layout of your website.. its basic and I can "view source" it whenever I want.. I was commenting on Zulf's post Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276969 Share on other sites More sharing options...
ZulfadlyAshBurn Posted October 7, 2011 Share Posted October 7, 2011 AyKay47: i do agree with you for that reason. michaelburt: set the graphics to center and add a color to the div. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276970 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 To be honest, I would love to center all the content, but I can't right now because I would have to modify the banner (to center it too). And I lost the original gimp file for my banner, meaning I would have to do it all over. And what to you mean by a color to the divs? The divs have images as their background. Sorry if I misunderstood your post, but I don't really understand what you mean by that. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276971 Share on other sites More sharing options...
AyKay47 Posted October 7, 2011 Share Posted October 7, 2011 I am currently at work and the screen resolution is very high... your site is not centered and the banner repeats..will need fixed Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276974 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 At the moment I am trying to make these suggestions happen! I'm trying to center everything and get the banner fixed. I'll update here when it's done. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276977 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 The updates are in place, are there any issues? Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276980 Share on other sites More sharing options...
AyKay47 Posted October 7, 2011 Share Posted October 7, 2011 centering is fine.. banner still repeats.. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276984 Share on other sites More sharing options...
michaelburt Posted October 7, 2011 Author Share Posted October 7, 2011 Try resetting your cache, I uploaded a new graphic. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276985 Share on other sites More sharing options...
AyKay47 Posted October 7, 2011 Share Posted October 7, 2011 doesn't repeat now.. text is still not centered in the banner.. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1276995 Share on other sites More sharing options...
doddsey_65 Posted October 7, 2011 Share Posted October 7, 2011 The standard fixed with site is usually 960px in width. If you like the letter spacing then why not declare a doctype and use css to modify the letter-spacing? Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1277109 Share on other sites More sharing options...
michaelburt Posted October 8, 2011 Author Share Posted October 8, 2011 Actually in response to the last post that's exactly what I did! Just used the letter-spacing attribute (before I used text-spacing, which isn't actually valid, and I didn't know there was an alternative). As for the text in the banner not being centered; I already discussed this, I lost the original .xcf (gimp) image file so I can't modify that image. I would have to create another banner from scratch. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1277134 Share on other sites More sharing options...
KevinM1 Posted October 8, 2011 Share Posted October 8, 2011 Letter-spacing isn't adversely affected by a doctype. What a doctype does is ensure your site renders in standards mode. Without a doctype, your site is rendered in quirks mode, which is bad as it essentially uses the old IE (<= 6) box model, which is, to be blunt, screwed up. If anything made things look bad, it was that you designed without a doctype first, then tried to add one in after the fact. What looked good in quirks mode naturally looked bad in standards mode. Quote Link to comment https://forums.phpfreaks.com/topic/248601-my-website/#findComment-1277135 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.