Any idea why namespace aliasing won't work?

[Andy-H]

PHP 5.3.2-1

 

 

This works fine:

define('ENV', 'DEVELOPMENT');
include '../com/config/bootstrap.php';
try {
   /**
     * SET NAMESPACE ALIASES
     */
   //use \com\controllers as Controller;
   //use \com\models      as Model;
   /**
     * ESTABLISH CONNECTION TO DATABASE
     */
   $dbh = new PDO('mysql:dbname='. DB .';host='. DB_HOST, DB_USER, DB_PASS);
   $dbh->setAttribute(PDO::MYSQL_ATTR_INIT_COMMAND, "SET NAMES 'UTF8'");
   $dbh->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
   
   if ( isset($_GET['path']) )
   {
      $path       = explode('/', $_GET['path']);
      $Controller = '\\com\\controllers\\'. ucfirst($path[0]);
      $Controller = new $Controller;
   }
} catch ( PDOException $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => 'Could not connect to database'));
   //$e->getMessage();
} catch ( ClassNotFoundException $e ) {
   echo $e->getMessage();
} catch ( Exception $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => $e->getMessage()));
}

 

 

but when I try

 

 

 

define('ENV', 'DEVELOPMENT');
include '../com/config/bootstrap.php';
try {
   /**
     * SET NAMESPACE ALIASES
     */
   use \com\controllers as Controller;
   //use \com\models      as Model;
   /**
     * ESTABLISH CONNECTION TO DATABASE
     */
   $dbh = new PDO('mysql:dbname='. DB .';host='. DB_HOST, DB_USER, DB_PASS);
   $dbh->setAttribute(PDO::MYSQL_ATTR_INIT_COMMAND, "SET NAMES 'UTF8'");
   $dbh->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
   
   if ( isset($_GET['path']) )
   {
      $path       = explode('/', $_GET['path']);
      $Controller = 'Controller\\'. ucfirst($path[0]);
      $Controller = new $Controller;
   }
} catch ( PDOException $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => 'Could not connect to database'));
   //$e->getMessage();
} catch ( ClassNotFoundException $e ) {
   echo $e->getMessage();
} catch ( Exception $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => $e->getMessage()));
}

I get server error, access denied to page, any ideas why?

 

 

Thanks

 

// EDIT, forgot to uncomment use com\controllers, as soon as I uncomment this, I get the error, regardless of whether I use the aliased namespace or not.

[trq]

What is the exact error?

[Andy-H]

I'm not sure, my works server is set up weird, I have display_errors on and error_reporting E_ALL | E_STRICT but I just get a 500 server error. I don't know why it does this?

[trq]

Check your server log.

[Andy-H]

Just checked php.ini and log errors is off

[trq]

Still, so turn it on.

[Andy-H]

Checked apache log, unexpected T_USE in index.php on line 8

[Andy-H]

Was because use was inside of the curly braces

http://www.php.net/manual/fa/language.namespaces.importing.php#98908

<?php
define('ENV', 'DEVELOPMENT');
include '../com/config/bootstrap.php';
use com\controllers as Controller;
use \com\models      as Model;
try {
   /**
     * SET NAMESPACE ALIASES
     */
   /**
     * ESTABLISH CONNECTION TO DATABASE
     */
   $dbh = new PDO('mysql:dbname='. DB .';host='. DB_HOST, DB_USER, DB_PASS);
   $dbh->setAttribute(PDO::MYSQL_ATTR_INIT_COMMAND, "SET NAMES 'UTF8'");
   $dbh->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
   
   if ( isset($_GET['path']) )
   {
      $path       = explode('/', $_GET['path']);
      $Controller = 'Controller\\'. ucfirst($path[0]);
      $Controller = new $Controller;
   }
} catch ( PDOException $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => 'Could not connect to database'));
   //$e->getMessage();
} catch ( ClassNotFoundException $e ) {
   echo $e->getMessage();
} catch ( Exception $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => $e->getMessage()));
}
?>

Works, however, it still doesn't alias it and tries to resolve to Contoller/User.class.php ??

[Andy-H]

 

Tried :

 

 

<?php
define('ENV', 'DEVELOPMENT');
include '../com/config/bootstrap.php';
// Namespace aliases
use \com\controllers as Controller;
use \com\models      as Model;
try {
   /**
     * SET NAMESPACE ALIASES
     */
   /**
     * ESTABLISH CONNECTION TO DATABASE
     */
   $dbh = new PDO('mysql:dbname='. DB .';host='. DB_HOST, DB_USER, DB_PASS);
   $dbh->setAttribute(PDO::MYSQL_ATTR_INIT_COMMAND, "SET NAMES 'UTF8'");
   $dbh->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
   
   if ( isset($_GET['path']) )
   {
      $path       = explode('/', $_GET['path']);
      $Controller = ucfirst($path[0]);
      $Controller = new Controller\$Controller;
   }
} catch ( PDOException $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => 'Could not connect to database'));
   //$e->getMessage();
} catch ( ClassNotFoundException $e ) {
   echo $e->getMessage();
} catch ( Exception $e ) {
   echo json_encode(array('STATUS' => 'FATAL', 'MESSAGE' => $e->getMessage()));
}
?>

Getting unexpected T_NAMESPACE_SEPARATOR expected T_STRING on line 22, thinking maybe this behaviour isn't supported, although I'm sure it should be?

[trq]

Not like that it's not. Try;

 

$Controller = 'Controller\\' . ucfirst($path[0]);
$Controller = new $Controller;

[Andy-H]

I've tried that, it loads but just doesn't resolve Controller to \com\controllers

 

//EDIT, I also tried double quotes.

[trq]

Have you actually included the Controller class somehow?

[Andy-H]

It gets autoloaded

 

 

/**
  * AUTOLOAD CLASSES
  */
include 'ClassNotFoundException.class.php';
function __autoload($class)
{
   $class     = explode('\\', $class);
   $classname = array_pop($class);
   $file      = APPLICATION_PATH . implode(DIRECTORY_SEPARATOR, $class) . DIRECTORY_SEPARATOR . str_replace('_', DIRECTORY_SEPARATOR, $classname) .'.class.php';
   if ( !file_exists($file) )
      throw new ClassNotFoundException($file);
   include $file;
}

 

Catching ClassNotFoundException and echoing getMessage outputs :

/var/www/api.domain.com/Controller/User.class.php

[trq]

Catching ClassNotFoundException and echoing getMessage outputs :

/var/www/api.domain.com/Controller/User.class.php

 

Are you saying it isn't being autoloaded then?

[kicken]

$Controller = 'Controller\\' . ucfirst($path[0]);
$Controller = new $Controller;

 

Importing is performed at compile-time, and so does not affect dynamic class, function or constant names.

 

Doesn't work with dynamic names.  You'll probably just have to include the full namespace in the string rather than try and do a use statement.

 

[Andy-H]

$Controller = 'Controller\\' . ucfirst($path[0]);
$Controller = new $Controller;

 

Importing is performed at compile-time, and so does not affect dynamic class, function or constant names.

 

Doesn't work with dynamic names.  You'll probably just have to include the full namespace in the string rather than try and do a use statement.

 

 

That's an oversight surely? Is this expected behaviour? I would have thought if I double quoted the namespace alias it would interpolate like a variable does :/

 

 

Is there a better way than this to load controllers anyway??

 

 

Also, I am unsure as to how I would inject objects into methods doing things this way, as my controller can't take arguments, is it common for controllers to contain references to super global arrays or have I overlooked something?

 

 

Also, how would you recommend injecting my PDO object into dependant classes?

[trq]

Is there a better way than this to load controllers anyway??

 

Also, I am unsure as to how I would inject objects into methods doing things this way, as my controller can't take arguments, is it common for controllers to contain references to super global arrays or have I overlooked something?

 

Also, how would you recommend injecting my PDO object into dependant classes?

 

I'm not sure any of these questions can be answered in a simple forum post. There are much more robust ways of loading controllers. And any dependencies they need should be loaded in via the __construct.

 

As for loading PDO. That is a prime candidate for dependency injection. Google it.

 

There is a link to my framework in my signature, it's still in a pre-alpha stage, but it's well worth a look at.

[Andy-H]

The idea was to inject PDO into my controllers, but then I'm creating a database connection for every request, what if I don't need one? I get all the concepts of OOP, and know a few design patterns, it's just putting them into use that I always struggle with, maybe I'm concentrating too much on creating the perfect application rather than "an application" :/

 

 

I've read a lot about your proem framework, it looks impressive But we're running 5.3, is 5.4 stable now?

[trq]

5.4 is at 5.4.3 now. Stable.

 

PDO does not belong in your controllers. You should only be accessing the database via Models.