Update_Not_Working

[RON_ron]

Could someone tell what's wrong with the below code? it's not updating the database?

 

$result = sprintf("UPDATE student_db1 SET completed='Yes', name='".$sname."' WHERE id ='%s'", mysql_real_escape_string($sid));

$results = mysql_query($result);

[kicken]

Echo your query out with var_dump($result) before you run it to make sure it is valid. Try running it manually in something like PHPMyAdmin or mysql console and check for errors.

[RON_ron]

it's strange.... echo works.... is there anything wrong in that piece of code?

[Jessica]

When you ran it in mysql or phpmyadmin it worked?

 

See the link in my signature.

[White_Lily]

Hmm... you've got "%s" in your code where i believe it updates the 'id'? Is it supposed to be like that?

Edited September 25, 2012 by White_Lily

[Jessica]

White_lily look up sprintf.

[Barand]

White_Lily: see manual http://uk3.php.net/m...ion.sprintf.php

 

Sorry, these warnings about previous posts don't work too well :-\

Edited September 25, 2012 by Barand

[White_Lily]

Hmm, ive never had to use that o.o

[Jessica]

There's not much reason to in this example, OP could be using PDO for a better way to do the same thing.

[PFMaBiSmAd]

I'm going to guess that your $sname variable contains some sql special characters and since you don't appear to be escaping that variable before putting it into the query statement, you are getting an sql syntax error.

 

Why are you building a query statement using two different methods of putting values into it, one for $sname and a different one for $sid? Consistency does count in programming.

 

There's around a half-dozen three-quarters of a dozen of different things that could cause your query to not update the database. If everything is perfect up to the point of the code you did post, that query should work.

 

Here's a list of the things that could prevent your update query from working -

1. You don't have a database connection at the point where you are running the query.
   
2. You haven't selected any database or have selected the wrong one.
   
3. The php code where the query is at is not being executed.
   
4. The query is failing with an error due to a wrong table or column name.
   
5. The query is failing due to some sql special characters in the $sname variable.
   
6. The WHERE clause is false because $sid is empty or doesn't match any id in your table.
   
7. The wrong column is being used in the WHERE clause. Is the column you are trying to match id? or is it something else?
   
8. The values you are updating the columns to are not compatible with the column type.
   
9. The value you are updating the columns to are the same as what they already are.
   
10. any more that I forgot to think of...
    

It's up to you to troubleshoot what your code and your data are doing on your server to pin down why something does not work. You need to devise tests to check each of these possible reasons to either eliminate it as the cause of the problem or to find that it is the cause of the problem.