Removing Comma

[madness69]

hello there, im trying to remove the last comma in my code, how coould i?

 

$query  = "SELECT email FROM users WHERE level = '2'";
$result = mysql_query($query);

while($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
   echo "{$row['email']}, "
	 ;
}

 

Best regards

[TOA]

You can't since you're echoing your content right away.

 

Try capturing your output first like this:

$query = "SELECT email FROM users WHERE level = '2'";
$result = mysql_query($query);

while($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
 // capture it so we can remove extra comma later
 $html .= "{$row['email']}, ";
}
// since it's on an end, we can use a form of trim
$html = rtrim($html, ', ');
// now echo it
echo $html;

[fesan]

I'm no expert but cant you just do it like this:

 

$query = "SELECT email FROM users WHERE level = '2'";
$result = mysql_query($query);

while($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
 echo $row['email'];
}

[TOA]

He wanted comma separated, which added one to the end. What you posted would just keep adding them on one line with no breaks or spaces.

 

But, you made me rethink me previous post and @OP, there's an alternative (IMO better) way:

$query = "SELECT email FROM users WHERE level = '2'";
$result = mysql_query($query);

$emails = array();
while($row = mysql_fetch_array($result, MYSQL_ASSOC))
{
	 // add each one to the array
	 $emails[] = "{$row['email']}";
}
// now we implode() the array adding commas, which will avoid our last one for us
$html = implode($emails, ',');
// now echo it
echo $html;

Edited October 18, 2012 by TOA

[fesan]

Yea...

 

Sorry! Did not get that at first...

[Christian F.]

TOA: Why this?

$emails[] = "{$row['email']}"

 

Completely unnecessary use of quotes and the advanced string syntax, I'd do away with both:

$emails[] = $row['email'];

[TOA]

@christian - because that's how he had it and I didn't re-write the entire thing, just made some small changes to show usage. But, good point and worth noting OP

Edited October 18, 2012 by TOA