Image Upload

[subhomoy]

i wanted to upload a image in godaddy server with a php script. It worked on my computer, 3owl.com. but when ever i'm trying to upload in godaddy's server, i'm getting an error...

 

The script is

<?php include('_header.php'); ?> <------- Database connection is done here.
<?php
if(!isset($_SESSION['email']))
   header("Location:index.php");
?>
<?php
$pid=$_REQUEST['uid'];
?>
  <?php
if(isset($_REQUEST['Submit'])){
//define a maxim size for the uploaded images in Kb
define ("MAX_SIZE","10000000");
//This function reads the extension of the file. It is used to determine if the file is an image by checking the extension.
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}
//This variable is used as a flag. The value is initialized with 0 (meaning no error found) and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded.
$errors=0;
//checks if the form has been submitted
if(isset($_POST['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['image']['name'];
//if it is not empty
if ($image)
{
//get the original name of the file from the clients machine
$filename = stripslashes($_FILES['image']['name']);
//get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
//if it is not a known extension, we will suppose it is an error and will not upload the file, otherwize we will do more tests
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif"))
{
//print error message
echo '<h1>Unknown extension!</h1>';
$errors=1;
}
else
{
//get the size of the image in bytes
//$_FILES['image']['tmp_name'] is the temporary filename of the file in which the uploaded file was stored on the server
$size=filesize($_FILES['image']['tmp_name']);
//compare the size with the maxim size we defined and print error if bigger
if ($size > MAX_SIZE*1024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}
//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="upload/".$image_name;
//we verify if the image has been uploaded, and print error instead
$copied = copy($_FILES['image']['tmp_name'], $newname); <-------------- here i'm getting the error.
$sql="INSERT INTO images (image_id,product_id,images_link) VALUES('', '$pid', '$newname')";
$result= mysql_query($sql);
if (!$copied)
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}}}}
//If no errors registred, print the success message
if(isset($_POST['Submit']) && !$errors)
{
echo "<strong><font size='4' color='#2497e0'>Image Added Successfully</font></strong>";
}
}
?>
<form name="newad" method="post" enctype="multipart/form-data" action="">
<table>
<tr><td><input type="file" name="image"></td></tr>
<tr><td><input name="Submit" type="submit" value="Upload image"></td></tr>
</table>
</form>

 

And the error is

Warning: copy(upload/1359049130.jpg) [function.copy]: failed to open stream: Permission denied in D:\Hosting\7528824\html\Admin\product1.php on line 82

 

Any help guyssss....

 

Thanks in advance...

[1internet]

Instead of your getExtension function, you can just use:

$type = $_FILES['image']['type'];
$allowed = array('image/jpeg', 'image/png', 'image/gif');
if(in_array($type, $allowed)) {
//image upload code
}

I would also either concatenate the errors or add them in an array, and echo them all out at the end.

 

Instead of copy, why not use

move_uploaded_file($_FILES['image']['tmp_name'], $newname)

[requinix]

Make sure your upload/ folder has world-writable permissions: 0777.

 

[edit]

Instead of your getExtension function, you can just use:

$type = $_FILES['image']['type'];
$allowed = array('image/jpeg', 'image/png', 'image/gif');
if(in_array($type, $allowed)) {
//image upload code
}

Problem is that you can't trust the type - it's sent from the browser so it can be forged by a malicious user. Plus IE tends to use unusual values so you'd have to account for those.

Short of something like getimagesize (a good idea), checking the extension is the next best thing.

Edited January 24, 2013 by requinix

[subhomoy]

im still having the same problem....

Warning: move_uploaded_file(upload/1359091396.jpg) [function.move-uploaded-file]: failed to open stream: Permission denied in D:\Hosting\7528824\html\Admin\product1.php on line 82
Warning: move_uploaded_file() [function.move-uploaded-file]: Unable to move 'D:\Temp\php\php910C.tmp' to 'upload/1359091396.jpg' in D:\Hosting\7528824\html\Admin\product1.php on line 82

[requinix]

"Still", after you changed to using move_uploaded_file()? Did you do anything else?

[subhomoy]

no nothing else except the part u told me to do...

 

I think its with the php.ini file located in the server...

[requinix]

What about the php.ini? Neither move_uploaded_file() nor the 0777 permissions have to do with it.

[White_Lily]

I see a problem! Look at the second warning he posted and you will see he is moving a file to an image, rather than a directory.

Edited January 25, 2013 by White_Lily

[PFMaBiSmAd]

@White_Lily,

 

The destination is an (optional) path and the filename.

 

Programming is an exact science, Please don't post replies unless you absolutely know what the answer is.

[subhomoy]

"Still", after you changed to using move_uploaded_file()? Did you do anything else?

So what to do... i'm failing in every case... Any help...

[mikosiko]

requinix told you what to do several post ago... did you follow his advice?

 

Make sure your upload/ folder has world-writable permissions: 0777.

Edited January 25, 2013 by mikosiko