Jump to content

Simple table formatting question


tekkenfan2

Recommended Posts

Ok, so I have some code that takes the records in my database and outputs them in a table, but currently after the first record it starts spacing them incorrectly

 

Here is the code

<?php
require_once('config.php');
require_once('menu.php');
 
echo '<h1>View All Alien Interactions</h1>';
 
echo '<table>
    <tr>';
foreach($fields AS $label){
    echo "<th>{$label}</th>";
}

echo '<th>Edit</th><th>Delete</th>';
echo '</tr>';

 
$fields_str = '`contact_id`, `'.implode(array_keys($fields), '`, `').'`';
$sql = "SELECT {$fields_str} FROM `alien_abduction`";
 
foreach($dbh->query($sql) as $row) {
    echo '<tr>';

    foreach($fields AS $field=>$value){

        echo '<td>'.(isset($row[$field]) && strlen($row[$field]) ? $row[$field] : '&nbsp'.'</td>');
    }
    echo '</tr>';
    echo '<td><a href="edit.php?contact_id='.$row['contact_id'].'">Edit</a></td>';
    echo '<td><a href="delete.php?contact_id='.$row['contact_id'].'">Delete</a></td>';
    echo '</tr>';
echo '</table>';
}
?>

I just want it to start a new line after importing each record

 

This is a picture of what its curently doing, look at the second row, it just keeps adding all additional entries on this line (I whited out personal info)

O4CCkmC.png

Link to comment
https://forums.phpfreaks.com/topic/289346-simple-table-formatting-question/
Share on other sites

Remove the closing </tr> tag directly after the foreach loop, this is probably what is causing it.

 

If all you are doing is dumping the data in $row into <td> tags, then you can write while loop as.

while($row = mysql_fetch_row($result)
{
  echo '
  <tr>
    <td>' . implode('</td><td>', $row) . '</td>
    <td><a href="edit.php?contact_id='.$row['contact_id'].'">Edit</a></td>
    <td><a href="delete.php?contact_id='.$row['contact_id'].'">Delete</a></td>
   </tr>';
}

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.