Eliminating duplicated code

[NotionCommotion]

How can I cleanly and efficiently modify the following script so that I do not have to define the empty $user array twice?

 

    public function editRecord(){
        $id=isset($_GET['id'])?$_GET['id']:null;
        if(is_null($id)) {
            $user=array('id'=>0,'firstname'=>'','lastname'=>'','username'=>'','access_id'=>10);
        }
        else {
            $sql='SELECT id,firstname,lastname,username FROM users WHERE id=? AND sites_id=?';
            $stmt = $this->db->prepare($sql);
            $stmt->execute(array($id,$this->site->id));
            if(!$user=$stmt->fetch(PDO::FETCH_ASSOC)){
                $user=array('id'=>0,'firstname'=>'','lastname'=>'','username'=>'','access_id'=>10);
            }
        }
        $this->displayPage(__DIR__.'/templates/editRecord.html',array('user'=>$user,'access'=>$this->getList('access')));
    }

 

[ginerjm]

Initialize it at the start of your function?

[Ch0cu3r]

Define the user array at the start of the function. Then overwrite the $user array with the result from the database if one was returned

public function editRecord()
{
    // default user array
    $user=array('id'=>0,'firstname'=>'','lastname'=>'','username'=>'','access_id'=>10);

    $id= isset($_GET['id']) ? $_GET['id'] : null;
    
    if(!is_null($id))
    {
        $sql='SELECT id,firstname,lastname,username FROM users WHERE id=? AND sites_id=?';
        $stmt = $this->db->prepare($sql);
        $stmt->execute(array($id,$this->site->id));

        // if query returned a result, override $user array
        if($stmt->numCount() != 0)
            $user = $stmt->fetch(PDO::FETCH_ASSOC);
    }

    $this->displayPage(__DIR__.'/templates/editRecord.html',array('user'=>$user,'access'=>$this->getList('access')));
}

Edited August 5, 2015 by Ch0cu3r

[NotionCommotion]

Well, I feel rather silly.  Thanks for the help!

[NotionCommotion]

if($stmt->numCount() != 0)

 

Do you mean rowCount()? http://php.net/manual/en/pdostatement.rowcount.php

[Ch0cu3r]

Yes.