Recursive generator

[NotionCommotion]

The following works, but seems like it has one more loop than it should.  Better way to do so?  I could get rid of the generator and merge to an array, but the generator seems like a better solution.   Thanks

    private function doSomething(File $file)
    {
        foreach($this->getTextFiles($file) as $textFile) {
            // ...
        }
    }

    private function getTextFiles(File $file):\Generator
    {
        foreach($file->getChildren() as $child) {
            if($child instanceof IsTextFile) {
                yield $child;
            }
            else {
                 foreach($this->getTextFiles($child) as $grandChild) {
                     yield $grandChild;
                 }
            }
        }
    }

 

[requinix]

You can "yield from" another generator.

    private function getTextFiles(File $file):\Generator
    {
        foreach($file->getChildren() as $child) {
            if($child instanceof IsTextFile) {
                yield $child;
            }
            else {
                yield from $this->getTextFiles($child);
            }
        }
    }

 

[NotionCommotion]

Thanks, exactly what I was hoping for!  Tried without the "from" but obviously didn't do what I wished for.