mysql_real_escape_string breaking \n

[Nolongerused3921]

The title says it all, for some reason mysql_real_escape_string breaks \n... Even with stripslashes().
How do I fix this...?

[redbullmarky]

you say "breaks" - but you dont give an example mentioning who/how/why/what/when etc.

"Breaks" is quite a general term here - can you be more specific, especially with the results you're getting?

[Nolongerused3921]

[quote]
Fixed's 'should''' be ''' workingrnrnrnrnYAY!
[/quote]

Was inserted as
[quote]
Fixed's 'should''' be ''' working



YAY!
[/quote]
Or something similar... I had just fixed my $_POST import function (To parse it all before a user has access to it), and it turns out it wasn't calling mysql_real_escape_string, so I added it and now er... It seems to have broken the ability for new lines to work.

Portion of the $_POST import function (The only part of it that pertains to this, the entire function is over 70 lines)
[code]
<?php
if (get_magic_quotes_gpc()) {
$tmp_data = stripslashes($tmp_data);
}
if ($filter_type == 2) {
$tmp_data = htmlentities($tmp_data);
$tmp_data = mysql_real_escape_string(strip_tags(trim($tmp_data)));
} elseif (!is_numeric($tmp_data)) {
//Then we can finish this.. otherwise it should be safe if it's just a number..
$tmp_data = htmlspecialchars($tmp_data, ENT_QUOTES);
$tmp_data = mysql_real_escape_string(strip_tags(trim($tmp_data)));
}
?>
[/code]

My content/bbcode parsing (The part that is called in order to strip slashes, convert nl2br, convert bbcode, etc.):
[code]
<?php
    function bbcode($data, $bbcode_on = TRUE){
    $db = $this->db_class;
        if ($db->is_connected() == NOT_CONNECTED){
            $db->connect();
        }

        $data = htmlspecialchars($data);
$data = stripslashes($data);
$pattern = array();
$replacement = array();
$bbcode = $GLOBALS['bbcode'];
if ($bbcode_on = TRUE) {
for ($i = 0; $i != count($bbcode); $i++) {
if ($bbcode[$i][type] == "bbcode") {
array_push($pattern,$bbcode[$i][pattern]);
array_push($replacement,$bbcode[$i][replacement]);
}
if ($bbcode[$i][type] == "smiley") {
$data = str_replace($bbcode[$i][pattern], "<img src='".$this->rdir."images/smilies/".$bbcode[$i][replacement]."' />", $data);
}
}
$data = preg_replace($pattern, $replacement, $data);
        }

        $data = str_ireplace(chr(10), "<br />\n", $data);
        nl2br($data);
        return $data;
    }

function content($data, $bbcode_on = TRUE) {
$data = html_entity_decode($data);
$data = $this->bbcode($data, $bbcode_on);
return $data;
}
?>
[/code]

All content is sent through content($data, TRUE/FALSE), and this is what is [b]now[/b] screwing it up, but prior to adding real_mysql_escape_string, it was working fine.

[Nolongerused3921]

Why was my post edited...?

[redbullmarky]

[quote]
Why was my post edited...?
[/quote]
because i put [ code] [ /code] tags which makes things about 4,000,000 times easier to read. otherwise, nothing was changed.

[Nolongerused3921]

Okay thanks, but er... Is there an answer to my question?

[Jessica]

It looks fine. \r\n is the equivalent to a new line. Why do you say it's not working? Can you show a live example, not just copy and paste text?

[Nolongerused3921]

It... Doesn't convert it to actual new lines, that quote I pasted was after it ran through content(), in an html area...
As for showing a live example - it'd take me awhile, as I'm currently testing locally...

[Jessica]

They look like new lines to me...

[Nolongerused3921]

Errr sorry about the confusion...
[quote]
Fixed's 'should''' be ''' workingrnrnrnrnYAY!
[/quote]
Thats what the html output is, as in - what a person would see if they were viewing that article....

What I actually wrote, and commited to the database was:
[quote]
Fixed's 'should''' be ''' working



YAY!
[/quote]

[Jessica]

You're probably calling stripslashes too many times. Take it out?

[Nolongerused3921]

If I take it out, it just shows as \n\n\n\n\n... Its not parsing it for some reason

[Jessica]

Because those aren't new lines in HTML. Run it through nl2br.

[redbullmarky]

[url=http://www.php.net/nl2br]nl2br[/url]??

[b]edit[/b]: pipped again ;)

[Nolongerused3921]

I did run it through nl2br, look at the bottom of the bbcode function...  :(

[redbullmarky]

yes but you're not capturing its return. you need

[code]
$data = nl2br($data);
[/code]

[Nolongerused3921]

Nope... Still not working, same output regardless of where $data = stripslashes($data); and $data = nl2br($date); are placed

[Jessica]

Okay you have to take OUT the stripslashes, and use nl2br. Not both.

[Nolongerused3921]

I have taken out stripslashes altogether as well

[redbullmarky]

was this: $data = nl2br($date) a typo in your post, or a typo in your code?
[code]
$data = nl2br($data);
[/code]

[Nolongerused3921]

Yes it was a typo in the post... Too bad, I thought it was that simple :(

And this may help a bit... The data from MySQL (Unedited, directly from phpmyadmin) :
[quote]
Wonder\r\n\r\n\r\n\r\n\r\n\r\nIf\r\n\r\n\r\nTHis\r\nREALLY\r\n\r\n\r\nWORKS\r\n\r\n!?
[/quote]
(I wrote a new string to just test this and not stripping \')

The html from the edit area:
[code]
<textarea name="content" cols="80" rows="20">Fixed \r\n\r\nit\r\n\r\nshould\r\n\r\n\r\n\r\nwork\r\n\r\n\r\n\r\n\r\nNOW!</textarea>
[/code]

From just printing the item:
[code]
Fixed \r\n\r\nit\r\n\r\nshould\r\n\r\n\r\n\r\nwork\r\n\r\n\r\n\r\n\r\nNOW!
[/code]

The code to print it:
[code=php:0]
<?php print $parser->content($temp_data[content]); ?>
[/code]

[Nolongerused3921]

Don't suppose anyone knows...? Was kind of hoping to figure this out so I could finish this up

[Jessica]

...
<?php print nl2br($parser->content($temp_data[content])); ?>
*shrug*

[Nolongerused3921]

Nope :( nl2br is already ran in content function (Shown in my first post)... For some reason its taking \n as a literal string and completely ignoring it

[Jessica]

Okay but did you try what I posted, or just say no?

What is $parser? It's probably something in there that's causing the problem then.
I give up, good luck.