Problem with thumb images

[jonw118]

I have a new website where the thumb images display VERY poorly. I want the images to display clearly.

 

I think it has something to do with the $thumbfactor, but as I change it, doesn't help the quality.

 

Can someone look at this and see if you see any setting you would change to make the thumb images not so grainy/pixelated?

 

Thanks much in advance:

 

function getImage($srcImg,$typImg){

 

	switch($typImg){

	case 1://Thumb
		$cStr = "th_";	
		break;
	case 2://Prev
		$cStr = "pr_";
		nreak;

}

$abc = explode("/",$srcImg);

 $thumbName = $cStr.$abc[count($abc)-1];

 $abc[count($abc)-1] = $thumbName;

 $abc = implode("/",$abc);

return $abc;


}

function aspectRatio($width, $height ,$thumbFactor){
//-------Image Manipulation Constants---//
	$thumbFactor  = 110;
	$imageThumbPrefix = "th_";
//-------------------------------------//

		if ($width > $height){
			$retWidth  = $thumbFactor;
			$retHeight = $thumbFactor * ($height / $width);


		}
		elseif ($width < $height){
			$retHeight  = 82;
			$retWidth   = $thumbFactor * $width / $height;


		}
		elseif ($width==$height){
			$retWidth  = $thumbFactor;
			$retHeight = 82 ;


		}
		else die ("unknown scenario");


		$outStr = $retWidth.",".$retHeight;
//			$outStr = "100,100";

	return $outStr;
}

function aspectRatio_user($width, $height ,$thumbFactor){
//-------Image Manipulation Constants---//
	$thumbFactor  = 115;
	$imageThumbPrefix = "th_";
//-------------------------------------//

		if ($width > $height){
			$retWidth  = $thumbFactor;
			$retHeight = $thumbFactor * ($height / $width);


		}
		elseif ($width < $height){
			$retHeight  = $thumbFactor;
			$retWidth   = $thumbFactor * $width / $height;


		}
		elseif ($width==$height){
			$retWidth  = $thumbFactor;
			$retHeight = $thumbFactor ;


		}
		else die ("unknown scenario");


	$outStr = $retWidth.",".$retHeight;
//		$outStr = "115,115";

[Fadion]

U're creating thumbs with GD i guess, as from what i quickly saw, your code only calculates the image dimensions. If so post that code, otherwise ive no idea.

[tibberous]

I might be able to round up some thumbnail code for you, but unless your site gets like 10 visitors a month, you want to cache thumbnails. Just after you make the image, store it in a folder, and then pull from the folder.

[jonw118]

Thanks for the help!

 

This is where I have no idea what I'm doing... this is a site we had custom programmed. I know just enough PHP to be dangerous when it comes to this.

 

This is something my developers never really addresses/fixed - the grainy images.

[TheFilmGod]

case 2://Prev
		$cStr = "pr_";
		nreak;

 

nreak needs to be "break"

[Fadion]

Still there is no explanation to this but anyway im giving my 2 cents. Usually u get grainy images when using a fixed width & height img tag and placing into it an image with different size, or with GD when using imagecopyresized() instead of imagecopyresampled(). Again i think the code u provided doesnt have to do with grainy images, only if u misscalculated image proportions which still dont think is the case.