[SOLVED] Search Problem

[cs1h]

Hi,

 

I'm not very good with php and can't see whats wrong with the following piece of code

 

$sql = "SELECT * FROM items WHERE (country='" . mysql_real_escape_string($targetb)" OR continent='" . mysql_real_escape_string($targetb) . "') AND type='" . mysql_real_escape_string($_POST['Type']) . "' AND (Abstract LIKE '%$keyword%' OR town LIKE '%$keyword%') ORDER BY id DESC";

 

Does anyone know why it doesn't work

 

Cheers

Colin

[BlueSkyIS]

what doesn't work? is there an error message? if you do mysql_query($sql) or die(mysql_error()), what is the error?

[Fadion]

A better looking and simple to debug code should be:

 

$targetb = mysql_real_escape_string($targetb); //or post or get data or whatever
$type = mysql_real_escape_string($_POST['Type']);

$sql = "SELECT * FROM items WHERE (country='$targetb' OR continent='$targetb') AND type='$type' AND (abstract LIKE '%$keyword%' OR town LIKE '%$keyword%') ORDER BY id DESC";

$results = mysql_query($sql) or die(mysql_error());

 

Note the "or die(mysql_error())", it should bring up the error caused. See what error ure getting.

[BlueSkyIS]

yes, and you'll probably find the error is here:

 

WHERE (country='" . mysql_real_escape_string($targetb)" OR

 

you're missing . and '

[cs1h]

Hi,

 

I changed it to

 

$targetb = $_POST['menuFilesDMA'];
$targetb = str_replace(' ','_', $targetb);
$targetb = mysql_real_escape_string($targetb);

$type = mysql_real_escape_string($_POST['Type']);

mysql_connect("localhost","adder","clifford"); 

mysql_select_db("real") or die("Unable to select database"); 

$keywords = preg_split("/[\s,]+/", trim($_POST['keyword']));

$sql = "SELECT * FROM items WHERE (country='$targetb' OR continent='$targetb') AND type='$type' AND (abstract LIKE '%$keyword%' OR town LIKE '%$keyword%') ORDER BY id DESC";

$result = mysql_query($sql) or die(mysql_error());

 

and now I get the error,

 

Warning: mysql_real_escape_string() [function.mysql-real-escape-string]: Access denied for user 'ODBC'@'localhost' (using password: NO) in D:\Inetpub\vhost\myroho.com\httpdocs\absearch.php on line 5

 

Warning: mysql_real_escape_string() [function.mysql-real-escape-string]: A link to the server could not be established in D:\Inetpub\vhost\myroho.com\httpdocs\absearch.php on line 5

 

Warning: mysql_real_escape_string() [function.mysql-real-escape-string]: Access denied for user 'ODBC'@'localhost' (using password: NO) in D:\Inetpub\vhost\myroho.com\httpdocs\absearch.php on line 7

 

Warning: mysql_real_escape_string() [function.mysql-real-escape-string]: A link to the server could not be established in D:\Inetpub\vhost\myroho.com\httpdocs\absearch.php on line 7

 

Any ideas why this is,

 

Thanks for all the help,

 

Colin

[sayedsohail]

Move the following lines under the mysql connect statement i.e,

 

mysql_connect("localhost","adder","clifford");

mysql_select_db("real") or die("Unable to select database");

 

$targetb = mysql_real_escape_string($targetb);

$type = mysql_real_escape_string($_POST['Type']);

 

This should solve your problem.

 

good luck.