Fatal error: Maximum execution time of 30 seconds exceeded

[ballhogjoni]

Fatal error: Maximum execution time of 30 seconds exceeded in /home/xxx/public_html/xxx/Home/home.php on line 82

 

What just happened, this use to work fine. I deleted stuff from the database but it shouldn't affect this code. Line 82 is commented below:

<?php
$rArticle = $db->Select('Articles','*','WHERE display_on_home_page = 1 LIMIT 1');
while ( $row = mysql_fetch_array( $rArticle ) ) {
if( !empty( $row['article_id'] ) ){
	$sTitle = $row['title'];
	$sTinyMCEData = $row['tinymcedata'];
}else{
	exit;
}
}

$iMaxCharacters = 300;
if( !empty( $sTinyMCEData ) ){
$sArticle = $sTinyMCEData; 
$sDisplayArticle = substr( $sArticle,$iMaxCharacters,1 );

if( $sDisplayArticle != " " ){
	$i=1;
	while( $sDisplayArticle != " " ){
		$iMaxCharacters = $iMaxCharacters+$i; //line 82
		$sArticle = $sTinyMCEData;
		$sDisplayArticle = substr( $sArticle,$iMaxCharacters,1 );
	}
}
}
?>

 

[btherl]

	if( $sDisplayArticle != " " ){
	$i=1;
	while( $sDisplayArticle != " " ){
		$iMaxCharacters = $iMaxCharacters+$i; //line 82
		$sArticle = $sTinyMCEData;
		$sDisplayArticle = substr( $sArticle,$iMaxCharacters,1 );
	}
}

 

Is it possible that $sDisplayArticle never becomes equal to " " ?  Try temporarily replacing this loop with a debug statement that prints out each $sDisplayArticle so you can verify that the values are what you expect.

[btherl]

Sorry I forgot to explain - the reason it times out is that your script runs "forever".  So I suspect that your loop there never terminates, and just keeps on looping until the 30 second limit kills it.

[maliary]

 

 

At certain times the error is brought about by an inadequate server. It takes too long to process and retrieve a query hence the error showing up.

[Zane]

you're not incrementing your $i variable

	$i=1;
	while( $sDisplayArticle != " " ){
		$iMaxCharacters = $iMaxCharacters+$i; //line 82
		$sArticle = $sTinyMCEData;
		$sDisplayArticle = substr( $sArticle,$iMaxCharacters,1 );
                        $i++ //		}

 

and you can just as easily increment iMaxCharacters like this too

$iMaxCharacters++;

you don't even need the $i variable

[JasonLewis]

Incrementing it by $i means it would increment by 1, then 2, then 3 etc etc.

 

So $iMaxCharacters, for example, starts at 0. After the first loop, it's 1. After the second loop, it's 3. After the third it would be 6 and so on.

 

Right?

 

I guess that's probably what you want then.

[Zane]

No, that's called squaring

[akitchin]

No, that's called squaring

 

hate to jump in here, but projectfear is right.  in the first iteration, $i = 1, so $iMaxCharacters would be 1.  next iteration, $i is 2, so $iMaxCharacters = 1+2 = 3.  and so on.

 

if one was squaring, there would be a common multiple between every member of the series (the base).

[Zane]

wow.....completely my bad on that one

 

didn't even look that over.  good thing I'm not getting paid

sorry projectfear

[JasonLewis]

No dramas. Is that what the OP was after though. Kind of strange to be doing it like that. Oh well.

[Zane]

Not used to seeing an $i=1 and no counter involved, caught me off guard.......he's apparently using the $i variable to hold 1 which is useless which is why I suggested

imaxcharacters++ in the first place..

 

 

well, it's back to square one on this one.  need some more information i guess

[ballhogjoni]

I guess I should explain what the fucntion does...It query's the db for an article and only display 300 characters of that article. Now let me explain the loop in question. It searches for the first instance of " " ( a space ) after the 300 character max. The loop is so that if a word falls under and over the 300 character max it will search for the space after that word and end. This way I am not cutting off the last word. Therefore I need the $i to stay constant at 1 because it just adds one each time it loops. I know I could just do ++ at the end of imaxcharacters and probably will make that change.

[akitchin]

what about strpos()?  no use reinventing the wheel.

[btherl]

This will give you the offset of the first space following the 300th character:

 

$offset = strpos($string, ' ', 300);

 

If there are no spaces then this will result in "false", so you must check for that value.  If it's not false, then you can use that number in substr()

[cooldude832]

even better why not use mysql to get the substr out of that database for you?

 

Less garbage out is always better