can i get hand please

[Jiraiya]

i have my script thats supposed to edit one variable if only if another variable is equal to or greater then 5 million but it dosnt seem to work here is the script

 

<?php

mysql_connect("localhost", "username", "password") or die(mysql_error());
mysql_select_db("members") or die(mysql_error());


$sql = mysql_query("SELECT * FROM users WHERE username = '$username'");
$row = mysql_fetch_array($sql);
if($row['skill'] > 5000000){
mysql_query("UPDATE `users` SET `village` = 'Akatsuki' WHERE username = '$username'") or die(mysql_error());
}
?>

[Maq]

Where do you get $username from?

You can just update it in 1 query.

 

$sql = "UPDATE `users` SET `village` = 'Akatsuki' WHERE username = '$username' AND skill > 5000000";
mysql_query($sql) or die(mysql_error());

[Jiraiya]

its supposed to update a users variable

[Maq]

I asked where it comes from not what it's supposed to do...

Can you post all of your code?

[Jiraiya]

is that right?

$username = $_COOKIE['ID_my_site'];

$sql = mysql_query("SELECT * FROM users WHERE username = '$username'");
$row = mysql_fetch_array($sql);
if($row['skill'] > 5000000){
mysql_query("UPDATE `users` SET `village` = 'Akatsuki' WHERE username = '$username'") or die(mysql_error());
}
?>

[revraz]

Sounds like your variables are empty.  Have you echo'd them to see?

[premiso]

Where do you get $username from?

You can just update it in 1 query.

 

$sql = "UPDATE `users` SET `village` = 'Akatsuki' WHERE username = '$username' AND skill > 5000000";
mysql_query($sql) or die(mysql_error());

 

This is how you should do it, instead of 2 querys as stated.

 

<?php
if (isset($_COOKIE['ID_my_site'])) {
     $username = $_COOKIE['ID_my_site']; 
     $sql = "UPDATE `users` SET `village` = 'Akatsuki' WHERE username = '$username' AND skill > 5000000";
     mysql_query($sql) or die(mysql_error());
}

 

As long as there is a username in the cookie that should work. (I would store the username in session as appose to a cookie but yea.)

[Maq]

Yes, premiso provides the correct example of how you should perform this query.

 

Also, as revraz stated, echo your variables to see what's inside.

 

echo "query: " . $sql . "
username: " . $username;

 

[Jiraiya]

this is what it displayed when i echoed it

query:

username:

[revraz]

Sounds like you have it in the wrong place, should be after your $sql variable

 

$sql = "UPDATE `users` SET `village` = 'Akatsuki' WHERE username = '$username' AND skill > 5000000";

 

echo "query: " . $sql . "<br />username: " . $username;

 

mysql_query($sql) or die(mysql_error());