[SOLVED] Select Query

[Xtremer360]

IS this okay to do?:

 

$query = 'SELECT * FROM shownames WHERE `type` = "$type"';
   		$result = mysql_query ( $query );
   		while ( $row = mysql_fetch_assoc ( $result ) ) 
  		{
   		print "<option value=\"".$row['showname']."\">".$row['showname']."</option>\r";
	}

[Maq]

Why, what don't you think is right about it?  Do you get errors/warnings?  You should error check your queries too:

 

$result = mysql_query($query) or die(mysql_error());

[Prismatic]

$query = "SELECT * FROM shownames WHERE `type` = '$type'";
         $result = mysql_query ( $query );
         while ( $row = mysql_fetch_assoc ( $result ) )
        {
         print "<option value=\"".$row['showname']."\">".$row['showname']."</option>\r";
      }

 

variables in single quoted strings are parsed literlly.

 

i changed the string to double quotes

[Adam]

you can use curly braces..

 

        $query = "SELECT * FROM shownames WHERE `type` = '$type'";
        $result = mysql_query($query) or die(mysql_error());
        while ($row = mysql_fetch_assoc($result))
        {
            print '<option value="{$row['showname']}">{$row['showname']}</option>\r';
        }

 

Or just escape from the string like:

 

print '<option value="' .$row['showname']. '">' .$row['showname']. '</option>\r';

 

Adam