Invalid argument supplied for foreach() warning

[mallen]

This part of my code is causing a  Invalid argument supplied for foreach() warning. I understand that the array is empty but not sure how to format this. This is used for importing a excell database. If there is no files for that particular item it will enter empty data to that table. Which is what I don't want. But making these changes causes the error.

if($data[11] == "" || empty($data[11]))
			$documents = "";
		else
			$documents = explode(",", $data[11]);

            
           
		foreach($documents as $addFile)
		{
			if(strpos($addFile, ".doc") !== false)
				$addFileType = "DOC";
			else
				$addFileType = "PDF";

[Jessica]

$documents = "";

Is not an array, you can't use foreach on it.

[mallen]

Solved it.

if ( ! empty($documents) )  // added

		foreach($documents as $addFile)

 

NowI just need to find a way to trim file names. Just ltrim() the document name.

[Jessica]

And the problem is???

[mallen]

And the problem is???

 

Sometimes there may be spaces before file names due to user error. If someone edits the exell file. Then when its imported I want to strip the blank space before entering it in the database.

 

 

$documents = explode(",", $data[11]);

[premiso]

... you said it yourself, using trim.

 

Not sure what you are trying to get at, without you pasting more code so we can see where the filename is being used / where the trim would need to apply.

 

Alternatively, you could just apply it to the whole documents array using array_filter

[mallen]

I have tried both of these.

 

$documents	= ltrim(explode(",", $data[11]));

$documents	= explode(",", ltrim($data[11]));

[Jessica]

You have to do it on each item, or use array_filter as premiso said.

[premiso]

Is $data[11] the item that needs trimmed? It seems like you are just exploding it.

 

$documents = explode(",", $data[11]);
array_walk($documents, 'ltrim');

 

Should do what you want, not really knowing what you want and thinking that you do not know what you want.

[mallen]

Thanks Premiso for trying to help me out with this. Yes I now what I want to do just not how to. I need to trim any blank or empty space that may appear before a document's name. I tried that and got this error:

Warning: array_walk() expects parameter 1 to be array, string given in

[Jessica]

You need to POST your code when you make changes, and post WHAT you tried.

[mallen]

 

You need to POST your code when you make changes, and post WHAT you tried.

* Please only comment if you are willing and able to help.

I posted the code I tried from premiso. I will post it again.

$documents = explode(",", $data[11]);

array_walk($documents, 'ltrim');

[premiso]

if ( ! empty($documents) && is_array($documents))  // added
		array_walk($documents, 'ltrim');
		foreach($documents as $addFile)

 

Try it like that.

 

Or like this:

 

if ( ! empty($documents) && is_array($documents))  // added
		array_walk($documents, 'ltrim');
		foreach($documents as $addFile) {
			$addFile = ltrim($addFile);

[Jessica]

I posted the code I tried from premiso. I will post it again.

No, YOU didn't. She posted that code. YOU posted an error. There are plenty of people who post on here who would read her post, change the code, and say it didn't work. There's no logical reason for that code to cause that error, explode CANNOT return a string. It can return a BOOLEAN or an array. Therefore, the REST of your code matters too.

 

 

 

* Please only comment if you are willing and able to help.

I'm certainly able, but if you're not able to learn how to GET help, you won't get it. Don't worry, I won't bother trying to help you anymore.

[PFMaBiSmAd]

array_walk cannot be used with call-back functions that return values. It needs to be used with call-back functions that modify a value that is passed by reference.

 

array_map works with a call-back function that return a value.

[mallen]

Premiso, Sorry I should have been more clear. This part of my code works. There is a addFile and also a addFileTYPE,  The addFile is the part that needs the spaces trimmed.

if($data[11] == "" || empty($data[11]))
			$documents = "";
		else
			$documents		= explode(",", $data[11]);

if ( ! empty($documents) )  

		foreach($documents as $addFile)
		{
			if(strpos($addFile, ".doc") !== false)
			$addFileType = "DOC";
			else
				$addFileType = "PDF";

			$insertAddFile = "INSERT INTO " FILES . "(`prod_id`, `file_name`, `file_type`) VALUES('$lastId', '$addFile', '$addFileType')";
			$wpdb->query($insertAddFile);

[Jessica]

SO TRIM THE VARIABLE. FFS.

[premiso]

*premiso facepalms

 

if ( ! empty($documents) && is_array($documents))  // added
		foreach($documents as $addFile) {
			$addFile = ltrim($addFile);

 

Should do what you want.

[mallen]

Thanks. I tried what you suggested and it changed all my file types to "PDF" and also didn't strip the spaces.

if ( ! empty($documents) )  

		foreach($documents as $addFile)
		{
			if(strpos($addFile, ".doc") !== false)
			$addFileType = "DOC";

			else
				$addFileType = "PDF";


	if ( ! empty($documents) && is_array($documents))  // added
		foreach($documents as $addFile) {
			$addFile = ltrim($addFile);

		}		



			$insertAddFile = "INSERT INTO ". FILES . "(`prod_id`, `file_name`, `file_type`) VALUES('$lastId', '$addFile', '$addFileType')";
			$wpdb->query($insertAddFile);
		}

[mallen]

Solved it.

if ( ! empty($documents) )

		foreach($documents as $addFile)
		{
			$addFile = ltrim($addFile);// <--- added here
			if(strpos($addFile, ".doc") !== false)
			$addFileType = "DOC";

			else
				$addFileType = "PDF";

[Jessica]

THATS WHAT SHE WROTE MY HEAD IS EXPLODING.