brokenglass Posted November 6, 2014 Share Posted November 6, 2014 Hi guys, Does anyone know why my code isn't working?: $servername="127.0.0.1"; $username="root"; $password=""; $dbname="testdb"; $connection = new mysqli($servername,$username,$password); $result = "SELECT 'Country' from 'w'"; echo '<select>'; foreach($result as $res) { echo '<option value="'.$res['Country'].'">' . $res['Country'] . '</option>'; } echo '</select>'; } There's not a credential issue, the table is called 'w' and the collumn I'm trying to get the values from is 'Country' Any help is appreciated. Cheers, Broken Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/ Share on other sites More sharing options...
Solution Barand Posted November 6, 2014 Solution Share Posted November 6, 2014 (edited) Having defined the query string you need to execute the query then get the results. Also, your mysqli connection needs the dbname as the 4th argument. $connection = new mysqli($servername,$username,$password,$dbname); $sql = "SELECT Country from w "; $r = $connection->query($sql); $result = $r->fetch_all(MYSQLI_ASSOC); echo '<select>'; foreach($result as $res) { echo '<option value="'.$res['Country'].'">' . $res['Country'] . '</option>'; } echo '</select>'; edit: Nearly missed it - don't quote table and column names, and it does help to use meaningful names rather than just w Edited November 6, 2014 by Barand Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495905 Share on other sites More sharing options...
brokenglass Posted November 6, 2014 Author Share Posted November 6, 2014 Having defined the query string you need to execute the query then get the results. Also, your mysqli connection needs the dbname as the 4th argument. $connection = new mysqli($servername,$username,$password,$dbname); $sql = "SELECT Country from w "; $r = $connection->query($sql); $result = $r->fetch_all(MYSQLI_ASSOC); echo '<select>'; foreach($result as $res) { echo '<option value="'.$res['Country'].'">' . $res['Country'] . '</option>'; } echo '</select>'; edit: Nearly missed it - don't quote table and column names, and it does help to use meaningful names rather than just w Thanks mate, but I get this now: Fatal error: Call to a member function fetch_all() on a non-object in C:\xampp\htdocs\test\index.php on line 16 Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495908 Share on other sites More sharing options...
Barand Posted November 6, 2014 Share Posted November 6, 2014 see what error you have $r = $connection->query($sql) or die($connection->error); Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495909 Share on other sites More sharing options...
brokenglass Posted November 6, 2014 Author Share Posted November 6, 2014 see what error you have $r = $connection->query($sql) or die($connection->error); That also returns an error. Here's my full code <?php $servername="127.0.0.1"; $username="root"; $password=""; $dbname="testdb"; $connection = new mysqli($servername,$username,$password,$dbname); if($connection->connect_error){ die("Connection failed " . $connection->connect_error); }else{ $sql = "SELECT 'Country' from 'w'"; $r = $connection->query($sql); $result = $r->fetch_all(MYSQLI_ASSOC); echo '<select>'; foreach($result as $res) { echo '<option value="'.$res['Country'].'">' . $res['Country'] . '</option>'; } echo '</select>'; } ?> Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495912 Share on other sites More sharing options...
cyberRobot Posted November 6, 2014 Share Posted November 6, 2014 That also returns an error. What error does it give? Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495913 Share on other sites More sharing options...
brokenglass Posted November 6, 2014 Author Share Posted November 6, 2014 What error does it give? You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''w'' at line 1 Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495915 Share on other sites More sharing options...
cyberRobot Posted November 6, 2014 Share Posted November 6, 2014 Did you try removing the single quotes as Barand suggested? Try changing this $sql = "SELECT 'Country' from 'w'"; To this $sql = "SELECT Country from w"; Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495916 Share on other sites More sharing options...
brokenglass Posted November 6, 2014 Author Share Posted November 6, 2014 Did you try removing the single quotes as Barand suggested? Try changing this $sql = "SELECT 'Country' from 'w'"; To this $sql = "SELECT Country from w"; Thanks man, that now works kind of. It displays the dropdown box with 3 entries (my collumn has 3 entries) but in each collumn it just says Countries rather than the 3 entries in the collumn (English, France, Argentina) Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495918 Share on other sites More sharing options...
cyberRobot Posted November 6, 2014 Share Posted November 6, 2014 It displays the dropdown box with 3 entries (my collumn has 3 entries) but in each collumn it just says Countries rather than the 3 entries in the collumn (English, France, Argentina) Did you remove the single quotes around 'Country'? The query should be $sql = "SELECT Country from w"; Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495919 Share on other sites More sharing options...
brokenglass Posted November 6, 2014 Author Share Posted November 6, 2014 Did you remove the single quotes around 'Country'? The query should be $sql = "SELECT Country from w"; You're a genius. Cheers mate. Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495920 Share on other sites More sharing options...
cyberRobot Posted November 6, 2014 Share Posted November 6, 2014 No problem; glad to help For future reference, if you need to surround a column name with quotes because it's a reserved word in MySQL or maybe the column name contains spaces, you use backticks: $sql = "SELECT `limit` from w"; Quote Link to comment https://forums.phpfreaks.com/topic/292311-getting-values-of-dropdown-from-mysql-not-working/#findComment-1495921 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.