PHP search box

[Renato]

I'm creating search box, to search users on my database

 

this is the form

<form action='' method='get' >
    <input type='text' name='search' />
    <input type='submit' value='search'/>	<br/>
</form>

php

<?php
$search = $_GET['search'];

$terms = explode( " ", $search);
$query = "SELECT * FROM login WHERE";

foreach ($terms as $each) {
	$i++;
	
	if ($i==0)
		$query .= "username like '%$each%' ";
	else
		$query .= "OR username like '%$each%' ";
	}
	mysql_connect("localhost", "renatov_admin", "password1!") or die (mysql_error());
	mysql_select_db("renatov_database") or die ("could not find bd!");
	
	$squery = mysql_query($query);
	$numrows = mysql_num_rows($query);
	if ($numrows > 0){
	
	while($row = mysql_fetch_assoc($query)){
			$username = $row['username'];
			$nationality = $row['nationality'];
			$age = $row['age'];
			$search = $row['search'];
			
			
			echo "<h2><a href='$link'>$username</a> </h2>";
		
		}
	
	}
	else	
		echo "No results found for \"<b>$search</b> \"";
	
	mysql_close();
?>

it comes with error:

Warning: mysql_num_rows() expects parameter 1 to be resource, string given

 

Is always "No result found for"

Can someone tell me where I'm doing wrong?

 

[requinix]

$query is just the string SQL query. You want $squery, which is the actual result of executing the query (or at least trying to).

[Renato]

I've try to, it didn't work.

 

When I search it shows on URL, the word that has been input to the search box.

[CroNiX]

Requinix is saying that $query here, needs to be $squery:

$numrows = mysql_num_rows($query);

[Renato]

Requinix is saying that $query here, needs to be $squery:

$numrows = mysql_num_rows($query);

 

I have change to $squery; 

but i still get error -Warning: mysql_num_rows() expects parameter 1 to be resource, boolean

 

And still get no results when search for username. 

[CroNiX]

Then most likely your query is failing, but you never check for that and just assume it runs .  See how they do it in http://php.net/manual/en/function.mysql-query.php in the first example labeled "Example #1 invalid query"

 

My guess is because you don't have a space after the WHERE and when you add to the query.

 

As a side note, mysql is deprecated and will be removed from PHP in the future. You should be using PDO or mysqli if you don't want to have to rewrite all of this for newer upcoming versions of PHP. You're not doing yourself any favors by using something that is already deprecated.

Edited January 6, 2015 by CroNiX

[hansford]

Do yourself a favor to save frustration - echo out your query before hitting the database.

echo $query;
exit();

$squery = mysql_query($query);
$numrows = mysql_num_rows($squery);

[ginerjm]

At the least you need a space after WHERE