foreach by reference

[ginerjm]

Thought I understood how this works but having a problem making it work.

Here is my code:

foreach($_SESSION['golf_entrants'] as &$row)
{
if ($row['id_code'] == $id)
{
$row['entry_name'] == $name;
$updated = true;
}
}

 

$row is a two element array that is created by a fetchall from a query that grabs them.

If my argument ($id) matches the element for a given row I want to replace the row's name value with the new $name value.

 

Nothing is being altered at all.

[mac_gyver]

$row['entry_name'] == $name;

^^^ this is a comparison, not an assignment, so one would expect nothing to be altered.

[requinix]

Advice: any time you do a foreach by-reference, unset the variable after the loop. Or don't use references at all. Otherwise you might accidentally use the variable later in your code and create some really unusual bugs.

 

And please, indent your code.

foreach($_SESSION['golf_entrants'] as &$row)
{
	if ($row['id_code'] == $id)
	{
		$row['entry_name'] = $name;
		$updated = true;
	}
}
unset($row);

[ginerjm]

OMG! I was so wrapped up in the 'by reference' thing that I didn't see the obvious typo in front of me.

 

Thanks for the quick response.