Null Safe Operator

[NotionCommotion]

The following four methods were changed.  The first three seem to be correct but not sure about the last one (hasPhysicalMedia).  Agree?  Best way to fix is just type casting the returned value?  Thanks

 

     public function getPhysicalMedia(): ?PhysicalMedia
     {
-        return $this->activeMedia?$this->activeMedia->getPhysicalMedia():null;
+        return $this->activeMedia?->getPhysicalMedia();
     }

     public function getMediaType(): ?MediaType
     {
-        return $this->activeMedia?$this->activeMedia->getMediaType():null;
+        return $this->activeMedia?->getMediaType();
     }

     public function getFilename(): ?string
     {
-        return $this->activeMedia?$this->activeMedia->getFilename():null;
+        return $this->activeMedia?->getFilename();
     }

     public function hasPhysicalMedia(): bool
     {
-        return $this->activeMedia && $this->activeMedia->hasPhysicalMedia();
+        return $this->activeMedia?->hasPhysicalMedia();
     }

class ActiveMedia
{
    public function getPhysicalMedia(): PhysicalMedia
    {
        return $this->physicalMedia;
    }

    public function getMediaType(): ?MediaType
    {
        return $this->mediaType;
    }

    public function getFilename(): ?string
    {
        return $this->filename;
    }

    public function hasPhysicalMedia(): bool
    {
        return (bool) $this->physicalMedia;
    }
}

 

[requinix]

Fix what? A null will be coerced to false.