writing in php

[brown2005]

?>
                <select onchange="window.open(this.options[this.selectedIndex].value,'_top')" class='text'>
<?
echo"            <option></option>";
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=1"' ?> <?php Rate($page1, "1");?>>1</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=2"' ?> <?php Rate($page1, "2");?>>2</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=3"' ?> <?php Rate($page1, "3");?>>3</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=4"' ?> <?php Rate($page1, "4");?>>4</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=5"' ?> <?php Rate($page1, "5");?>>5</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=6"' ?> <?php Rate($page1, "6");?>>6</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=7"' ?> <?php Rate($page1, "7");?>>7</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=8"' ?> <?php Rate($page1, "8");?>>8</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=9"' ?> <?php Rate($page1, "9");?>>9</option> <?
?> <?php echo'  <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate=10"' ?> <?php Rate($page1, "10");?>>10</option> <?
echo" </select>";

i need to change all the above into php, if someone could point me in the right direction with the select bit and the first option i could do the rest, thanks in advance...

p.s. i have tried but when i go onto page it comes up blank..

thanks in advance

[trq]

Um... it is in php.

[Jessica]

What does Rate() do?
This should be close, depending on what Rate() is for.
[code]for($i=1; $i<=10; $i++){
  echo '<option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$id.'&rate='.$i.'">'.$i.'</option>';
  Rate($page1, $i);
}[/code]

[brown2005]

what I mean is that i want to get rid of all the <? and ?>

[trq]

[quote]what I mean is that i want to get rid of all the <? and ?>[/quote]

Are your fingers broken? Well do it. Were not here to write out code for you.

[brown2005]

yes but what i am saying is how I would usually do it i cant get it to work.

[redbullmarky]

then post the result of your attempt and we can go from there....

[Jessica]

Uhm, did you try what I posted?

[brown2005]

hi, i have tried

echo"          <font class='text_red_bold'>Rate:&nbsp;&nbsp;</font>";

echo'          <select class="text_red_bold" onchange="window.open(this.options[this.selectedIndex].value,\_top\)">';
echo'            <option></option>';

for($i=1; $i<=10; $i++)
{

echo' <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$website_id.'&rate='.$i.'">'.$i.'</option>'; Rate($page1, $i);

}

echo'          </select>';

and it doesnt do anything

[Jessica]

Then the problem might be elsewhere. Where is $page1 defined? As I asked before, what does Rate() do? Are you getting any errors?

[brown2005]

i have that

function Rate($page, $file)
{

if ($page == $file) echo "selected=\"selected\"";

}


and it goes to http://www.randomhomepage.co.uk/homepages/files/rate.php file

[brown2005]

hi i have seen you have put

echo' <option value="http://www.randomhomepage.co.uk/homepages/files/rate.php?id='.$website_id.'&rate='.$i.'">'.$i.'</option>'; Rate($page1, $i);

but this is in the <option> tag on the original, dont know if that matters

[brown2005]

sorry this Rate($page1, $i); was in the <option Rate($page1, $i);> like that.. in the original..

any ideas please?