Help with my attacking script

[werny]

I can't figure out how to get this to work

<?php
require_once 'appinclude.php';
$con = mysql_connect("myhost","myaccount","mypassword");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("mydatabase", $con);

$result = mysql_query("SELECT * FROM members
WHERE id='$user'");
$row = mysql_fetch_assoc($result);
$attackroll = $row['attackroll'];
$defendroll = $row['defendroll'];
$defendwin = "$defendroll"-"$attackroll";
$attackwin = "$attackroll"-"$defendroll";
$attackerpower = $row['attackpower'];
$defendpower = $row['cpudefense'];
$defendupdate = "$attackerpower"-"$defendwin";
$attackupdate = "$defendpower"-"$attackwin";
$numbattacker = rand(1,6);
$numbdefender = rand(1,6);
echo "you rolled a $numbattacker The enemy rolled a $numbdefender <br />";
$query = "UPDATE members SET attackroll = '$numbattacker' WHERE id='$user'";
mysql_query($query);
$query = "UPDATE members SET defendroll = '$numbdefender' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);
if ("$attackroll"<"$defendroll")
   echo "you lose";
   $query = "UPDATE members SET attackpower = '$defendupdate' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);
if ("$attackroll">"$defendroll")
echo "you win!";
$query = "UPDATE members SET cpudefense = '$attackupdate' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);
?>

it will show what you and the computer rolled, but it won't insert the values correctly..

[Jessica]

if ("$attackroll">"$defendroll")

 

You're comparing strings here. Take out the quotes around them to compare numbers.

[werny]

still doesnt work, it just wont actually update the winners army, or the defenders army with the losses, it is making me mad 

[darkfreaks]

try

 

<?php

$attackroll = $row[attackroll];
$defendroll = $row[defendroll];

$defendwin = $defendroll-$attackroll;
$attackwin = $attackroll-$defendroll;
?>

[Fadion]

Where are the curly braces? Shouldnt the code be like:

 

if($a<$b){
  //blah blah
} else{
  //some other blah blah
}

[Fadion]

try

<?php

$attackroll = $row[attackroll];
$defendroll = $row[defendroll];
?>

 

Returned indexes are strings so that will not work.

[darkfreaks]

Like jesirose suggested take the "" out.

[darkfreaks]

Try:

 

<?php
require_once 'appinclude.php';
$con = mysql_connect("myhost","myaccount","mypassword");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("mydatabase", $con);

$result = mysql_query("SELECT * FROM members
WHERE id='$user'");
$row = mysql_fetch_assoc($result);
$attackroll = $row['attackroll'];
$defendroll = $row['defendroll'];
$defendwin = $defendroll-$attackroll;
$attackwin = $attackroll-$defendroll;
$attackerpower = $row['attackpower'];
$defendpower = $row['cpudefense'];
$defendupdate = $attackerpower-$defendwin;
$attackupdate = $defendpower-$attackwin;
$numbattacker = rand(1,6);
$numbdefender = rand(1,6);
echo "you rolled a $numbattacker The enemy rolled a $numbdefender <br />";
$query = "UPDATE members SET attackroll = '$numbattacker' WHERE id='$user'";
mysql_query($query);
$query = "UPDATE members SET defendroll = '$numbdefender' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);

if ($attackroll<$defendroll){
   echo "you lose";
   $query = "UPDATE members SET attackpower = '$defendupdate' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);}

if ($attackroll>$defendroll){
echo "you win!";
$query = "UPDATE members SET cpudefense = '$attackupdate' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);}



?>

[werny]

Try:

 

<?php
require_once 'appinclude.php';
$con = mysql_connect("myhost","myaccount","mypassword");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("mydatabase", $con);

$result = mysql_query("SELECT * FROM members
WHERE id='$user'");
$row = mysql_fetch_assoc($result);
$attackroll = $row['attackroll'];
$defendroll = $row['defendroll'];
$defendwin = $defendroll-$attackroll;
$attackwin = $attackroll-$defendroll;
$attackerpower = $row['attackpower'];
$defendpower = $row['cpudefense'];
$defendupdate = $attackerpower-$defendwin;
$attackupdate = $defendpower-$attackwin;
$numbattacker = rand(1,6);
$numbdefender = rand(1,6);
echo "you rolled a $numbattacker The enemy rolled a $numbdefender <br />";
$query = "UPDATE members SET attackroll = '$numbattacker' WHERE id='$user'";
mysql_query($query);
$query = "UPDATE members SET defendroll = '$numbdefender' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);

if ($attackroll<$defendroll){
   echo "you lose";
   $query = "UPDATE members SET attackpower = '$defendupdate' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);}

if ($attackroll>$defendroll){
echo "you win!";
$query = "UPDATE members SET cpudefense = '$attackupdate' WHERE id='$user'";
mysql_query($query);
mysql_fetch_assoc($result);}



?>

 

tried and still the results in the database are messed up, sometimes it adds, and sometimes it takes away troops from the database, I am just tempted sometimes to make a database that I dont care about and give someone the password and help me out...

[darkfreaks]

i pmed you on yahoo but no response

[werny]

i pmed you on yahoo but no response

im not seeing it, send it to my main email, [email protected]

[AndyB]

If that's the whole script, where does the variable $user come from?

[Timma]

I highly doubt they want to post the script for their entire game.

[MadTechie]

i'm sure AndyB was talking about the script of the file in question.. not the script to the whole project!

[Timma]

Yes, he may be asking that, but...

 

require_once 'appinclude.php';

[MadTechie]

in which case the reply would be

 

from "appinclude.php",

 

remember if you assume something you make an ass out of u and me

 

lol

[werny]

Yes, he may be asking that, but...

 

require_once 'appinclude.php';

yeah its made in for facebook, so $user is defined the in included files, that isnt the problem

[darkfreaks]

From what i saw your script was working correctly? what exactly do you mean it isnt adding up right? ???