flashbangpro Posted August 27, 2012 Share Posted August 27, 2012 Hello I have created a MySQL database and tables with vehicle information and maintenance information. I have added an update link in the table output, so maintenance information can be updated. I click the link and it takes me to the maintenance html form I created. when I hit submit I have it sending to the update script. It updates all the records not just the record I selected update on. Here is the code for my table output page where I have the option to update a record. Could the problem be here? Here is the code I have for the pages involved. Form Page: <?php require_once("dbcon.php"); ?> <?php require_once("functions.php"); ?> <?php // get value of id that sent from address bar $id=$_GET['id']; // Retrieve data from database $sql="SELECT * FROM $tbl_name WHERE id='$id'"; $result=mysql_query($sql); $rows=mysql_fetch_array($result); ?> <html> <body> <h1>Maintenace Report </h1> <section> <section> <form method="post" name="form1" action="updated_maint.php"> <table align="center"> <tr valign="baseline"> <th nowrap align="right">Date of next scheduled maintenance:</th> <td> <input type="text" name="date_next_maint" value="" size="32"> </tr> <tr valign="baseline"> <th nowrap align="right">Maintenace/Repair Issues Reported:</th> <td> <textarea name="issues_reported" rows="3" cols="27"></textarea> </tr> <tr valign="baseline"> <th nowrap align="right">Date That Maintenace/Repair Issues Reported:</th> <td> <input type="text" name="date_reported" value="" size="32"> </tr> <tr valign="baseline"> <th nowrap align="right">Scheduled Service Date That Maintenace/Repair Issues Reported:</th> <td> <input type="text" name="scheduled_service_date" value="" size="32"> </tr> <tr valign="baseline"> <th nowrap align="right">Maintenace/Repair Service Performed W/Comments:</th> <td> <textarea name="service_performed" rows="3" cols="27"></textarea> </tr> <tr valign="baseline"> <th nowrap align="right">Date Maintenace/Repair Service Performed:</th> <td><input type="text" name="date_service_performed" value="" size="32"></td> </tr> <tr valign="baseline"> <th nowrap align="right">Date OF Follow-up Work / If Needed:</th> <td> <input type="text" name="date_of_followup" value="" size="32"> </tr> <tr valign="baseline"> <th nowrap align="right">Service In Progress:</th> <td> <input type="radio" name="service_in_progress" value="0" /> No <input type="radio" name="service_in_progress" value="1" /> Yes </tr> <tr valign="baseline"> <th nowrap align="right">Date Return To Use:</th> <td> <input type="text" name="date_return_use" value="" size="32"> </tr> <tr valign="baseline"> <th nowrap align="right">Time Return Use:</th> <td> <input type="text" name="time_return_use" value="" size="32"> </tr> <tr valign="baseline"> <th nowrap align="right">Nonrepaiable Issues Found W/Comments:</th> <td> <textarea name="issues_nonrepairable" rows="3" cols="27"></textarea> </tr> <tr valign="baseline"> <th nowrap align="right">Date Nonrepaiable Issues Found:</th> <td> <input type="text" name="date_nonrepairable_issues" value="" size="32"> </tr> <tr valign="baseline"> <th nowrap align="right">Comments:</th> <td> <textarea name="comments" rows="3" cols="27"></textarea> </tr> <tr valign="baseline"> <td nowrap align="right"> </td> <td><input type="submit" value="Insert record"></td> </tr> </table> <input type="hidden" name="MM_insert" value="form1"> </form> <a href="maint_list_update.php">Cancel</a> <p> </p> </section> <!-- end .content --></h2> </section> </body> </html> Update Page: <?php require_once("dbcon.php"); ?> <?php require_once("functions.php"); ?> <?php $date_next_maint = mysql_prep($_POST['date_next_maint']); $issues_reported = mysql_prep($_POST['issues_reported']); $date_reported = mysql_prep($_POST['date_reported']); $scheduled_service_date = mysql_prep($_POST['scheduled_service_date']); $service_performed = mysql_prep($_POST['service_performed']); $date_service_performed = mysql_prep($_POST['date_service_performed']); $date_of_followup = mysql_prep($_POST['date_of_followup']); $service_in_progress = mysql_prep($_POST['service_in_progress']); $date_return_use = mysql_prep($_POST['date_return_use']); $time_return_use = mysql_prep($_POST['time_return_use']); $issues_nonrepairable = mysql_prep($_POST['issues_nonrepairable']); $date_nonrepairable_issues = mysql_prep($_POST['date_nonrepairable_issues']); $comments = mysql_prep($_POST['comments']); ?> <?php $query = "UPDATE service_info SET `date_next_maint`='$date_next_maint', `issues_reported`='$issues_reported', `date_reported`='$date_reported', `scheduled_service_date`='$scheduled_service_date', `service_performed`='$service_performed', `date_service_performed`='$date_service_performed', `date_of_followup`='$date_of_followup',`service_in_progress`='$service_in_progress', `date_return_use`='$date_return_use', `time_return_use`='$time_return_use', `issues_nonrepairable`='$issues_nonrepairable', `date_nonrepairable_issues`='$date_nonrepairable_issues', `comments` ='$comments'"; $result = mysql_query($query, $connection); if ($result) { // Success! redirect_to("maint_list_update.php"); } else { // Display error message. echo "<p>Maintenance Info Creation Failed.</p>"; echo "<p>" . mysql_error() . "</p>"; } ?> Update Record Page - <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <title>Service Order Database</title> <link href="nav.css" rel="stylesheet" type="text/css"><!--[if lt IE 9]> <script src="http://html5shiv.googlecode.com/svn/trunk/html5.js"></script> <![endif]--> </head> <body> <?php require_once("dbcon.php"); ?> <?php require_once("functions.php"); ?> <?php $query="SELECT * FROM service_info ORDER BY id"; $result=mysql_query($query); $num=mysql_numrows($result); mysql_close(); echo "<b><center>Database Output</center></b><br><br>"; // process form when posted if(isset($_POST['value'])) { if($_POST['value'] == 'Engine') { // query to get all Engine records $query = "SELECT * FROM servifce_info WHERE issues_reported='Engine'"; }elseif($_POST['value'] == 'Transmission') { // query to get all Transmission records $query = "SELECT * FROM servifce_info WHERE issues_reported='Transmission'"; }elseif($_POST['value'] == 'Differential') { // query to get all Differential records $query = "SELECT * FROM servifce_info WHERE issues_reported='Differential'"; }elseif($_POST['value'] == 'Electrical') { // query to get all Electrical records $query = "SELECT * FROM servifce_info WHERE issues_reported='Electrical'"; }elseif($_POST['value'] == 'Tires') { // query to get all Tires records $query = "SELECT * FROM servifce_info WHERE issues_reported='Tires'"; }elseif($_POST['value'] == 'Brakes') { // query to get all Brakes records $query = "SELECT * FROM servifce_info WHERE issues_reported='Brakes'"; }elseif($_POST['value'] == 'HVAC') { // query to get all HVAC records $query = "SELECT * FROM servifce_info WHERE issues_reported='HVAC'"; }elseif($_POST['value'] == 'Lighting') { // query to get all Lighting records $query = "SELECT * FROM servifce_info WHERE issues_reported='Lighting'"; }elseif($_POST['value'] == 'Accident Damage') { // query to get all Accident Damage records $query = "SELECT * FROM servifce_info WHERE issues_reported='Accident Damage'"; } else { // query to get all records $query = "SELECT * FROM servifce_info "; } mysql_close(); } ?> <html> <head></head> <body> <form action='<?php echo $_SERVER['PHP_SELF']; ?>' method='post' name='form_filter' > <select name="value"> <option value="all">All</option> <option value="Engine">Engine</option> <option value="Transmission">Transmission</option> <option value="Differential">Differential</option> <option value="Electrical">Electrical</option> <option value="Tires">Tires</option> <option value="Brakes">Brakes</option> <option value="HVAC">HVAC</option> <option value="Lighting">Lighting</option> <option value="Accident">Accident</option> </select> <br /> <input type='submit' value = 'Filter'> </form> <div id="nav"> <ul> <li><a href="order_vehicle_name.php" title=""> ORDER BY VEHICLE NAME</a></li> <li><a href="order_vehicle_number.php" title=""> ORDER BY VEHICLE NUMBER</a></li> <li><a href="order_location.php" title=""> ORDER BY LOCATION</a></li> <li><a href="order_status.php" title=""> ORDER BY STATUS</a></li> <li><a href="order_issues_reported.php" title=""> ORDER REPORTED ISSUES</a></li> <li><a href="order_id.php" title=""> ORDER BY ID</a></li> <li><a href="index.php">LOG OUT</a></li> </ul> </div> <table border="1" cellspacing="5" cellpadding="5"> <tr> <th><font face="Arial, Helvetica, sans-serif">ID</font></th> <th><font face="Arial, Helvetica, sans-serif">Vehicle Name</font></th> <th><font face="Arial, Helvetica, sans-serif">Vehicle Number</font></th> <th><font face="Arial, Helvetica, sans-serif">Location</font></th> <th><font face="Arial, Helvetica, sans-serif">Status</font></th> <th><font face="Arial, Helvetica, sans-serif">RTS</font></th> <th><font face="Arial, Helvetica, sans-serif">Odometer Date</font></th> <th><font face="Arial, Helvetica, sans-serif">Odometer Reading Date</font></th> <th><font face="Arial, Helvetica, sans-serif">Date of next scheduled maintenance</font></th> <th><font face="Arial, Helvetica, sans-serif">Maintenace/Repair Issues Reported</font></th> <th><font face="Arial, Helvetica, sans-serif">Date Issues Reported</font></th> <th><font face="Arial, Helvetica, sans-serif">Scheduled Service Date Issues Reported</font></th> <th><font face="Arial, Helvetica, sans-serif">Repair Service Performed W/Comments</font></th> <th><font face="Arial, Helvetica, sans-serif">Date Service Performed</font></th> <th><font face="Arial, Helvetica, sans-serif">Date OF Follow-up</font></th> <th><font face="Arial, Helvetica, sans-serif">Service In Progress 0=NO 1=YES</font></th> <th><font face="Arial, Helvetica, sans-serif">Date Return To Use</font></th> <th><font face="Arial, Helvetica, sans-serif">Time Return Use</font></th> <th><font face="Arial, Helvetica, sans-serif">Nonrepaiable Issues Found W/Comments</font></th> <th><font face="Arial, Helvetica, sans-serif">Date Issues Found</font></th> <th><font face="Arial, Helvetica, sans-serif">Parts Cost</font></th> <th><font face="Arial, Helvetica, sans-serif">Hours Worked</font></th> <th><font face="Arial, Helvetica, sans-serif">Comments</font></th> <th><font face="Arial, Helvetica, sans-serif">Update</font></th> </tr> <?php $i=0; while ($i < $num) { $field1=mysql_result($result,$i,"id"); $field2=mysql_result($result,$i,"name"); $field3=mysql_result($result,$i,"number"); $field4=mysql_result($result,$i,"location"); $field5=mysql_result($result,$i,"status"); $field6=mysql_result($result,$i,"rts"); $field7=mysql_result($result,$i,"odomread"); $field8=mysql_result($result,$i,"odomdate"); $field9=mysql_result($result,$i,"date_next_maint"); $field10=mysql_result($result,$i,"issues_reported"); $field11=mysql_result($result,$i,"date_reported"); $field12=mysql_result($result,$i,"scheduled_service_date"); $field13=mysql_result($result,$i,"service_performed"); $field14=mysql_result($result,$i,"date_service_performed"); $field15=mysql_result($result,$i,"date_of_followup"); $field16=mysql_result($result,$i,"service_in_progress"); $field17=mysql_result($result,$i,"date_return_use"); $field18=mysql_result($result,$i,"time_return_use"); $field19=mysql_result($result,$i,"issues_nonrepairable"); $field20=mysql_result($result,$i,"date_nonrepairable_issues"); $field21=mysql_result($result,$i,"parts_cost"); $field22=mysql_result($result,$i,"hours"); $field23=mysql_result($result,$i,"comments"); ?> <tr> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field1; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field2; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field3; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field4; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field5; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field6; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field7; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field8; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field9; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field10; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field11; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field12; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field13; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field14; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field15; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field16; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field17; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field18; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field19; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field20; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field21; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field22; ?></font></td> <td><font face="Arial, Helvetica, sans-serif"><?php echo $field23; ?></font></td> <td><a href="maint_update.php?id=<? echo $rows['id']; ?>">update</a></td> </tr> <?php $i++; } ?> </body> </html> Please help and a great thank you in advance. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/ Share on other sites More sharing options...
jazzman1 Posted August 27, 2012 Share Posted August 27, 2012 So, between $query and $result variables in updated_maint.php, put this piece of code and give back a result, also add a mysql_error() function to the result variable. $query = "UPDATE service_info SET `date_next_maint`='$date_next_maint', `issues_reported`='$issues_reported', `date_reported`='$date_reported', `scheduled_service_date`='$scheduled_service_date', `service_performed`='$service_performed', `date_service_performed`='$date_service_performed', `date_of_followup`='$date_of_followup',`service_in_progress`='$service_in_progress', `date_return_use`='$date_return_use', `time_return_use`='$time_return_use', `issues_nonrepairable`='$issues_nonrepairable', `date_nonrepairable_issues`='$date_nonrepairable_issues', `comments` ='$comments'"; echo '<pre'.print_r($_POST, true).'</pre>'; echo $query; $result = mysql_query($query, $connection) or die(mysql_error()); Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372796 Share on other sites More sharing options...
Christian F. Posted August 27, 2012 Share Posted August 27, 2012 The reason it updates all records is simple: There is no WHERE clause in that query. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372812 Share on other sites More sharing options...
cyberRobot Posted August 27, 2012 Share Posted August 27, 2012 The form needs to pass the ID of the row being updated and you need to a WHERE clause in the update query (like ChristianF suggested). Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372814 Share on other sites More sharing options...
jazzman1 Posted August 27, 2012 Share Posted August 27, 2012 Guys, did you read a post of OP ? About а WHERE CLAUSE: The WHERE clause specifies which record or records that should be updated. If you omit the WHERE clause, all records will be updated! Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372828 Share on other sites More sharing options...
cyberRobot Posted August 27, 2012 Share Posted August 27, 2012 Guys, did you read a post of OP ? About а WHERE CLAUSE: The WHERE clause specifies which record or records that should be updated. If you omit the WHERE clause, all records will be updated! Hmm...where are you getting that quote from? Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372832 Share on other sites More sharing options...
jazzman1 Posted August 27, 2012 Share Posted August 27, 2012 Guys, did you read a post of OP ? About а WHERE CLAUSE: The WHERE clause specifies which record or records that should be updated. If you omit the WHERE clause, all records will be updated! Hmm...where are you getting that quote from? http://dev.mysql.com/doc/refman/5.0/en/update.html Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372834 Share on other sites More sharing options...
cyberRobot Posted August 27, 2012 Share Posted August 27, 2012 It updates all the records not just the record I selected update on. Unless I'm missing something, the OP doesn't want to update all entries. That's why we suggested the WHERE clause be added. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372837 Share on other sites More sharing options...
jazzman1 Posted August 27, 2012 Share Posted August 27, 2012 It updates all the records not just the record I selected update on. Unless I'm missing something, the OP doesn't want to update all entries. That's why we suggested the WHERE clause be added. Ah, you are right. I'm just translating this sentence wrong to my language. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372843 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 It updates all the records not just the record I selected update on. Unless I'm missing something, the OP doesn't want to update all entries. That's why we suggested the WHERE clause be added. Yes you are right, I only want to update the selected record. Here is the updated code I have for the update page and the error I am now getting. <?php require_once("dbcon.php"); ?> <?php require_once("functions.php"); ?> <?php $date_next_maint = mysql_prep($_POST['date_next_maint']); $issues_reported = mysql_prep($_POST['issues_reported']); $date_reported = mysql_prep($_POST['date_reported']); $scheduled_service_date = mysql_prep($_POST['scheduled_service_date']); $service_performed = mysql_prep($_POST['service_performed']); $date_service_performed = mysql_prep($_POST['date_service_performed']); $date_of_followup = mysql_prep($_POST['date_of_followup']); $service_in_progress = mysql_prep($_POST['service_in_progress']); $date_return_use = mysql_prep($_POST['date_return_use']); $time_return_use = mysql_prep($_POST['time_return_use']); $issues_nonrepairable = mysql_prep($_POST['issues_nonrepairable']); $date_nonrepairable_issues = mysql_prep($_POST['date_nonrepairable_issues']); $comments = mysql_prep($_POST['comments']); ?> <?php $query = "UPDATE service_info SET `date_next_maint`='$date_next_maint', `issues_reported`='$issues_reported', `date_reported`='$date_reported', `scheduled_service_date`='$scheduled_service_date', `service_performed`='$service_performed', `date_service_performed`='$date_service_performed', `date_of_followup`='$date_of_followup',`service_in_progress`='$service_in_progress', `date_return_use`='$date_return_use', `time_return_use`='$time_return_use', `issues_nonrepairable`='$issues_nonrepairable', `date_nonrepairable_issues`='$date_nonrepairable_issues', `comments` ='$comments' WHERE id='$id'"; $result = mysql_query($query, $connection); if ($result) { // Success! redirect_to("service_list_update.php"); } else { // Display error message. echo "<p>Maintenance Info Creation Failed.</p>"; echo "<p>" . mysql_error() . "</p>"; } ?> Error - Parse error: syntax error, unexpected '(' in /data/9/0/28/4/517493/user/528148/htdocs/jednewdb/updated_maint.php on line 19 Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372865 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 You should be able to debug basic parse errors. I don't even see a paren on line 19 or near it though that would cause a parse error. Is this the actual file. What is on lines 18-20 of the file? Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372889 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 Sorry you are right I pasted the wrong file, this is the right file and I am getting this error <?php require_once("dbcon.php"); ?> <?php require_once("functions.php"); ?> <?php $date_next_maint = mysql_prep($_POST['date_next_maint']); $issues_reported = mysql_prep($_POST['issues_reported']); $date_reported = mysql_prep($_POST['date_reported']); $scheduled_service_date = mysql_prep($_POST['scheduled_service_date']); $service_performed = mysql_prep($_POST['service_performed']); $date_service_performed = mysql_prep($_POST['date_service_performed']); $date_of_followup = mysql_prep($_POST['date_of_followup']); $service_in_progress = mysql_prep($_POST['service_in_progress']); $date_return_use = mysql_prep($_POST['date_return_use']); $time_return_use = mysql_prep($_POST['time_return_use']); $issues_nonrepairable = mysql_prep($_POST['issues_nonrepairable']); $date_nonrepairable_issues = mysql_prep($_POST['date_nonrepairable_issues']); $comments = mysql_prep($_POST['comments']); ?> <?php $query = "UPDATE service_info SET `date_next_maint`='$date_next_maint', `issues_reported`='$issues_reported', `date_reported`='$date_reported', `scheduled_service_date`='$scheduled_service_date', `service_performed`='$service_performed', `date_service_performed`='$date_service_performed', `date_of_followup`='$date_of_followup',`service_in_progress`='$service_in_progress', `date_return_use`='$date_return_use', `time_return_use`='$time_return_use', `issues_nonrepairable`='$issues_nonrepairable', `date_nonrepairable_issues`='$date_nonrepairable_issues', `comments` ='$comments' WHERE id=$id"; $result = mysql_query($query, $connection); if ($result) { // Success! redirect_to("service_list_update.php"); } else { // Display error message. echo "<p>Maintenance Info Creation Failed.</p>"; echo "<p>" . mysql_error() . "</p>"; } ?> Error - Maintenance Info Creation Failed. Unknown column '$id' in 'where clause' Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372892 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 Your error still doesn't seem to match, but regardless, you never defined $id before trying to use it. Add echo "<p>Error: " . mysql_error() . " SQL: $query</p>"; And see what the actual query looks like, once you've defined $id. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372893 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 I did the echo you suggested and this is what I got Maintenance Info Creation Failed. You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5 Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5 SQL: UPDATE service_info SET `date_next_maint`='testing', `issues_reported`='', `date_reported`='', `scheduled_service_date`='', `service_performed`='', `date_service_performed`='', `date_of_followup`='',`service_in_progress`='', `date_return_use`='', `time_return_use`='', `issues_nonrepairable`='', `date_nonrepairable_issues`='', `comments` ='' WHERE id= Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372899 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 Did you read the rest of my post? Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372900 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 I thought I defined id, here is the code I updated after your post. <?php require_once("dbcon.php"); ?> <?php require_once("functions.php"); ?> <?php $id=$_GET['id']; $date_next_maint = mysql_prep($_POST['date_next_maint']); $issues_reported = mysql_prep($_POST['issues_reported']); $date_reported = mysql_prep($_POST['date_reported']); $scheduled_service_date = mysql_prep($_POST['scheduled_service_date']); $service_performed = mysql_prep($_POST['service_performed']); $date_service_performed = mysql_prep($_POST['date_service_performed']); $date_of_followup = mysql_prep($_POST['date_of_followup']); $service_in_progress = mysql_prep($_POST['service_in_progress']); $date_return_use = mysql_prep($_POST['date_return_use']); $time_return_use = mysql_prep($_POST['time_return_use']); $issues_nonrepairable = mysql_prep($_POST['issues_nonrepairable']); $date_nonrepairable_issues = mysql_prep($_POST['date_nonrepairable_issues']); $comments = mysql_prep($_POST['comments']); ?> <?php $query = "UPDATE service_info SET `date_next_maint`='$date_next_maint', `issues_reported`='$issues_reported', `date_reported`='$date_reported', `scheduled_service_date`='$scheduled_service_date', `service_performed`='$service_performed', `date_service_performed`='$date_service_performed', `date_of_followup`='$date_of_followup',`service_in_progress`='$service_in_progress', `date_return_use`='$date_return_use', `time_return_use`='$time_return_use', `issues_nonrepairable`='$issues_nonrepairable', `date_nonrepairable_issues`='$date_nonrepairable_issues', `comments` ='$comments' WHERE id=$id"; $result = mysql_query($query, $connection); if ($result) { // Success! redirect_to("service_list_update.php"); } else { // Display error message. echo "<p>Maintenance Info Creation Failed.</p>"; echo "<p>" . mysql_error() . "</p>"; } echo "<p>Error: " . mysql_error() . " SQL: $query</p>"; ?> Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372902 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 Aaaaand? Is there an id in your URL? You need to provide more information, and make some attempts to figure it out. When you add something, don't just immediately tell us you did it, keep trying for a bit using the advice we've given already. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372903 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 I keep adapting my code with all the advice I get, when I get new errors I update to let everyone know the new error. What more information do you need? Let me know what more you need and I will gladly give it. Thank You Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372906 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 Aaaaand? Is there an id in your URL? Obviously you're still getting an error too, right? Or you wouldn't be posting. What does the query look like now? If it's the same, then you don't have id in your URL. Think it through. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372908 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 I am still getting the same error Maintenance Info Creation Failed. You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5 Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5 SQL: UPDATE service_info SET `date_next_maint`='testing', `issues_reported`='', `date_reported`='', `scheduled_service_date`='', `service_performed`='', `date_service_performed`='', `date_of_followup`='',`service_in_progress`='', `date_return_use`='', `time_return_use`='', `issues_nonrepairable`='', `date_nonrepairable_issues`='', `comments` ='' WHERE id= No there is no id in the url Url- maint_update.php?id= Should I repost all 3 of the updated files that I have? Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372916 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 So you don't see a problem with your URL being "maint_update.php?id=" ?? Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372917 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 Yes I see that problem, but I don't understand why it isn't getting the id of selected row to update. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372919 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 Is it that you don't understand why there is no ID in your URL, or that you don't understand why with a blank ID your query fails? Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372920 Share on other sites More sharing options...
flashbangpro Posted August 27, 2012 Author Share Posted August 27, 2012 I understand why the query would fail with a blank id, I don't understand why the id is blank. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372921 Share on other sites More sharing options...
Jessica Posted August 27, 2012 Share Posted August 27, 2012 the id is blank in your code because there is no id in your URL, and you're using $id=$_GET['id']. You need to find the code that generated that URL, and look for where the $id is set there. Trace back to where you create it in the first place. Quote Link to comment https://forums.phpfreaks.com/topic/267643-help-updating-mysql-database-tables/#findComment-1372922 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.