String to Uppercase Problem

[Dummy99]

My code doesn't work if I put in the uppercase statement, i.e., it accepts any character.

If I leave the uppercase statemnt out, my code works.

It seems to me my statement is correct.

{newent.value = strtoupper(newent.value)

if(newent.value == 'B' || newent.value == 'P' || newent.value == 'T'  || newent.value == 'D' )
    {EnterSw.value=0;return true;}
else{alert('INVALID HAND / MAIN INVALID');newent.select();return false;}}

Thanks for your help.

[requinix]

strtoupper is a PHP function. You are using Javascript. They are completely different things.

newent.value is (presumably) a string. This page may be helpful to show you what you can do with it.

[Dummy99]

Sorry. No insult to PHP intended. I had been told it was PHP code.

Many thanks for you help.

[ginerjm]

I offer this correction to your code.  It makes it easier to read and is better in the long run to learn to code this way.

you have:

if(newent.value == 'B' || newent.value == 'P' || newent.value == 'T'  || newent.value == 'D' )
    {EnterSw.value=0;return true;}
else{alert('INVALID HAND / MAIN INVALID');newent.select();return false;}}

This would be much better:

if(newent.value == 'B' || newent.value == 'P' || newent.value == 'T'  || newent.value == 'D' )
{
	EnterSw.value = 0;
	return true;
}
else
{
	alert('INVALID HAND / MAIN INVALID');
	newent.select();
	return false;
}

Note how I inserted the lines within the {} under the if and under the else.

Also - it is better to only put one statement per line to make it easier to find statements when you are developing that may be causing you problems.  Joining them into one line makes them harder to find.

[Psycho]

Try this

newent = newent.toUpperCase();

 

[ahmedarain24]

Based on the code you provided, it seems that you are trying to convert the value of `newent` to uppercase using the `strtoupper()` function. However, it appears that the uppercase conversion is not working as expected and accepting any character.

To properly convert the value to uppercase in JavaScript, you should use the `toUpperCase()` method instead of `strtoupper()`. Here's the corrected code:

```javascript
newent.value = newent.value.toUpperCase();

if (newent.value === 'B' || newent.value === 'P' || newent.value === 'T' || newent.value === 'D') {
    EnterSw.value = 0;
    return true;
} else {
    alert('INVALID HAND / MAIN INVALID');
    newent.select();
    return false;
}
```

With this modification, the `toUpperCase()` method will convert the value of `newent` to uppercase, and the subsequent comparisons will check against uppercase characters ('B', 'P', 'T', 'D').