cmgmyr Posted June 23, 2006 Share Posted June 23, 2006 I just got done re-designing my website. CSS is good and XHTML strict is good. The only problem is in Firefox...something is a little off with the tables for some reason and I can't quite figure it out.So here are 2 versions of the site.No Doc type - Looks ok in all browsers[a href=\"http://syracusecs.com/index.php\" target=\"_blank\"]http://syracusecs.com/index.php[/a]CSS good, XHTML strict - OK in IE but not Firefox, Opera[a href=\"http://syracusecs.com/index-x.php\" target=\"_blank\"]http://syracusecs.com/index-x.php[/a]Any ideas? Please feel free to tell me what you think.Additionally...I have been messing around with AJAX and put a few things in the site already.The forms don't do any validation yet...but they will soon.Thanks,-Chris Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/ Share on other sites More sharing options...
steviewdr Posted June 23, 2006 Share Posted June 23, 2006 Initial impressions are good.Its very image heavy. The nav could be done with simple a: hovers.Whats killing it with xhtml and not working across browsers is that its ALL TABLES. I am suprised at you, I though it would all have been css.I think you should try and convert/move over to css and that will solve your problems.When moving from your portfolio page to your home page in firefox - the page jumps to the left due to the scollbar. I had the same problem with my recent website and I put in overflow: scroll and it solved it - allbeit it including scroll bars on every page - but I think its ok.-steve Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-48828 Share on other sites More sharing options...
jcombs_31 Posted June 23, 2006 Share Posted June 23, 2006 Without digging through your source, I'm willing to be you have some extra padding in there somewhere, or possibly a margin. I think the site looks pretty decent. Too much white space at the top, content should start higher up. I think in general you actually have too much white space throughout the site.edit: now that I looked at your code you should seriously consider scrapping that and coding it by hand. Looks like you let Photoshp output the html for you. Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-48852 Share on other sites More sharing options...
cmgmyr Posted June 23, 2006 Author Share Posted June 23, 2006 Thanks for the replys guys, I will make a few changes and post them when completed.On my way out for now.Thanks,-Chris Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-48854 Share on other sites More sharing options...
cmgmyr Posted June 25, 2006 Author Share Posted June 25, 2006 WOW!Ok guys...After about 5-6 hours of work today I finally finished converting the tables to CSS (On the main page)Everything works and looks the same on all browsers!Let me know what you think.[a href=\"http://syracusecs.com/index.php\" target=\"_blank\"]http://syracusecs.com/index.php[/a]I will start working on converting some of the content pages from tables to css...there are only a few.Later,-Chris Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49244 Share on other sites More sharing options...
moberemk Posted June 25, 2006 Share Posted June 25, 2006 First off, add a line break after your DTD. It looks nicer. Both visually and code-wise, this looks pretty good. Your code is well-organized and readable, and there are no really big issues with your design. Aside from the underline-dissappears-on-hover-for-links thing that I personally don't like, good job! Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49359 Share on other sites More sharing options...
AndyB Posted June 25, 2006 Share Posted June 25, 2006 you might want to add a t into 'porfolio' :) Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49360 Share on other sites More sharing options...
cmgmyr Posted June 25, 2006 Author Share Posted June 25, 2006 Hey, Thanks again. I fixed the rollover, and also the "Portfolio" (can't catch them all)moberemk: what do you mean by DTD? ...sorryIs there anything else that I should change/add? Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49401 Share on other sites More sharing options...
moberemk Posted June 25, 2006 Share Posted June 25, 2006 [b]D[/b]ocument [b]T[/b]ype [b]D[/b]efinition. Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49433 Share on other sites More sharing options...
cmgmyr Posted June 25, 2006 Author Share Posted June 25, 2006 Ok cool, thanks. Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49441 Share on other sites More sharing options...
steviewdr Posted June 25, 2006 Share Posted June 25, 2006 At 800x600 your portfolio page is not user friendly - with two scroll bars.I would prefer you to make the webpage longer rather than putting a scroll on a small div.Overall - there are no problems/bugs with it.Are you going to allow something for people who have javascript disabled?-steve Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49464 Share on other sites More sharing options...
moberemk Posted June 26, 2006 Share Posted June 26, 2006 That's true. For a CSS-based layout, this still shows much of it's table-based origins. You really should get rid of all the extra images you have floating everywhere where you could just create it in CSS. Like in you navigation-that could just be som CSS blocks.In addition, your document doesn't have a very good semantic value to it. Try looking at your page without the linked CSS enabled, and see what you think of it then. Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49659 Share on other sites More sharing options...
cmgmyr Posted June 26, 2006 Author Share Posted June 26, 2006 I will work on the navigation more and try and make it all CSS.I took off the style sheet in FF, what are some ways that I can make it look better when doing this? Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49664 Share on other sites More sharing options...
moberemk Posted June 26, 2006 Share Posted June 26, 2006 Give it a document outline. For example, use an image replacement technique in your header to create that image, and use a CSS list for your navigation. Also, take out any extra images, like the big solid colour block to the left of your logo. Quote Link to comment https://forums.phpfreaks.com/topic/12736-critique-and-minor-help/#findComment-49676 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.