Jump to content

Archived

This topic is now archived and is closed to further replies.

cmgmyr

Critique And Minor Help

Recommended Posts

I just got done re-designing my website. CSS is good and XHTML strict is good. The only problem is in Firefox...something is a little off with the tables for some reason and I can't quite figure it out.

So here are 2 versions of the site.

No Doc type - Looks ok in all browsers
[a href=\"http://syracusecs.com/index.php\" target=\"_blank\"]http://syracusecs.com/index.php[/a]

CSS good, XHTML strict - OK in IE but not Firefox, Opera
[a href=\"http://syracusecs.com/index-x.php\" target=\"_blank\"]http://syracusecs.com/index-x.php[/a]

Any ideas? Please feel free to tell me what you think.

Additionally...I have been messing around with AJAX and put a few things in the site already.

The forms don't do any validation yet...but they will soon.

Thanks,
-Chris

Share this post


Link to post
Share on other sites
Initial impressions are good.
Its very image heavy. The nav could be done with simple a: hovers.

Whats killing it with xhtml and not working across browsers is that its ALL TABLES. I am suprised at you, I though it would all have been css.

I think you should try and convert/move over to css and that will solve your problems.

When moving from your portfolio page to your home page in firefox - the page jumps to the left due to the scollbar. I had the same problem with my recent website and I put in overflow: scroll and it solved it - allbeit it including scroll bars on every page - but I think its ok.

-steve

Share this post


Link to post
Share on other sites
Without digging through your source, I'm willing to be you have some extra padding in there somewhere, or possibly a margin. I think the site looks pretty decent. Too much white space at the top, content should start higher up. I think in general you actually have too much white space throughout the site.

edit: now that I looked at your code you should seriously consider scrapping that and coding it by hand. Looks like you let Photoshp output the html for you.

Share this post


Link to post
Share on other sites
Thanks for the replys guys, I will make a few changes and post them when completed.

On my way out for now.

Thanks,
-Chris

Share this post


Link to post
Share on other sites
WOW!

Ok guys...After about 5-6 hours of work today I finally finished converting the tables to CSS (On the main page)

Everything works and looks the same on all browsers!

Let me know what you think.
[a href=\"http://syracusecs.com/index.php\" target=\"_blank\"]http://syracusecs.com/index.php[/a]

I will start working on converting some of the content pages from tables to css...there are only a few.

Later,
-Chris

Share this post


Link to post
Share on other sites
First off, add a line break after your DTD. It looks nicer. Both visually and code-wise, this looks pretty good. Your code is well-organized and readable, and there are no really big issues with your design. Aside from the underline-dissappears-on-hover-for-links thing that I personally don't like, good job!

Share this post


Link to post
Share on other sites
you might want to add a t into 'porfolio' :)

Share this post


Link to post
Share on other sites
Hey, Thanks again. I fixed the rollover, and also the "Portfolio" (can't catch them all)

moberemk: what do you mean by DTD? ...sorry

Is there anything else that I should change/add?

Share this post


Link to post
Share on other sites
At 800x600 your portfolio page is not user friendly - with two scroll bars.
I would prefer you to make the webpage longer rather than putting a scroll on a small div.

Overall - there are no problems/bugs with it.

Are you going to allow something for people who have javascript disabled?

-steve

Share this post


Link to post
Share on other sites
That's true. For a CSS-based layout, this still shows much of it's table-based origins. You really should get rid of all the extra images you have floating everywhere where you could just create it in CSS. Like in you navigation-that could just be som CSS blocks.
In addition, your document doesn't have a very good semantic value to it. Try looking at your page without the linked CSS enabled, and see what you think of it then.

Share this post


Link to post
Share on other sites
I will work on the navigation more and try and make it all CSS.

I took off the style sheet in FF, what are some ways that I can make it look better when doing this?

Share this post


Link to post
Share on other sites
Give it a document outline. For example, use an image replacement technique in your header to create that image, and use a CSS list for your navigation. Also, take out any extra images, like the big solid colour block to the left of your logo.

Share this post


Link to post
Share on other sites

×

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.