Jump to content


Photo

Critique And Minor Help


  • This topic is locked This topic is locked
13 replies to this topic

#1 cmgmyr

cmgmyr
  • Members
  • PipPipPip
  • Advanced Member
  • 1,278 posts
  • LocationUSA

Posted 23 June 2006 - 03:23 PM

I just got done re-designing my website. CSS is good and XHTML strict is good. The only problem is in Firefox...something is a little off with the tables for some reason and I can't quite figure it out.

So here are 2 versions of the site.

No Doc type - Looks ok in all browsers
[a href=\"http://syracusecs.com/index.php\" target=\"_blank\"]http://syracusecs.com/index.php[/a]

CSS good, XHTML strict - OK in IE but not Firefox, Opera
[a href=\"http://syracusecs.com/index-x.php\" target=\"_blank\"]http://syracusecs.com/index-x.php[/a]

Any ideas? Please feel free to tell me what you think.

Additionally...I have been messing around with AJAX and put a few things in the site already.

The forms don't do any validation yet...but they will soon.

Thanks,
-Chris

#2 steviewdr

steviewdr
  • Moderators
  • Advanced Member
  • 1,364 posts
  • LocationIreland

Posted 23 June 2006 - 03:56 PM

Initial impressions are good.
Its very image heavy. The nav could be done with simple a: hovers.

Whats killing it with xhtml and not working across browsers is that its ALL TABLES. I am suprised at you, I though it would all have been css.

I think you should try and convert/move over to css and that will solve your problems.

When moving from your portfolio page to your home page in firefox - the page jumps to the left due to the scollbar. I had the same problem with my recent website and I put in overflow: scroll and it solved it - allbeit it including scroll bars on every page - but I think its ok.

-steve

#3 jcombs_31

jcombs_31
  • Staff Alumni
  • Advanced Member
  • 2,066 posts
  • LocationFL

Posted 23 June 2006 - 05:01 PM

Without digging through your source, I'm willing to be you have some extra padding in there somewhere, or possibly a margin. I think the site looks pretty decent. Too much white space at the top, content should start higher up. I think in general you actually have too much white space throughout the site.

edit: now that I looked at your code you should seriously consider scrapping that and coding it by hand. Looks like you let Photoshp output the html for you.

#4 cmgmyr

cmgmyr
  • Members
  • PipPipPip
  • Advanced Member
  • 1,278 posts
  • LocationUSA

Posted 23 June 2006 - 05:10 PM

Thanks for the replys guys, I will make a few changes and post them when completed.

On my way out for now.

Thanks,
-Chris

#5 cmgmyr

cmgmyr
  • Members
  • PipPipPip
  • Advanced Member
  • 1,278 posts
  • LocationUSA

Posted 25 June 2006 - 02:24 AM

WOW!

Ok guys...After about 5-6 hours of work today I finally finished converting the tables to CSS (On the main page)

Everything works and looks the same on all browsers!

Let me know what you think.
[a href=\"http://syracusecs.com/index.php\" target=\"_blank\"]http://syracusecs.com/index.php[/a]

I will start working on converting some of the content pages from tables to css...there are only a few.

Later,
-Chris

#6 moberemk

moberemk
  • Members
  • PipPipPip
  • Advanced Member
  • 695 posts

Posted 25 June 2006 - 01:13 PM

First off, add a line break after your DTD. It looks nicer. Both visually and code-wise, this looks pretty good. Your code is well-organized and readable, and there are no really big issues with your design. Aside from the underline-dissappears-on-hover-for-links thing that I personally don't like, good job!
Disclaimer: No matter how harsh I may be, I'm always IMO only.

#7 AndyB

AndyB
  • Staff Alumni
  • Advanced Member
  • 5,465 posts
  • LocationToronto

Posted 25 June 2006 - 01:26 PM

you might want to add a t into 'porfolio' :)
Legend has it that reading the manual never killed anyone.
My site

#8 cmgmyr

cmgmyr
  • Members
  • PipPipPip
  • Advanced Member
  • 1,278 posts
  • LocationUSA

Posted 25 June 2006 - 04:35 PM

Hey, Thanks again. I fixed the rollover, and also the "Portfolio" (can't catch them all)

moberemk: what do you mean by DTD? ...sorry

Is there anything else that I should change/add?

#9 moberemk

moberemk
  • Members
  • PipPipPip
  • Advanced Member
  • 695 posts

Posted 25 June 2006 - 07:36 PM

Document Type Definition.
Disclaimer: No matter how harsh I may be, I'm always IMO only.

#10 cmgmyr

cmgmyr
  • Members
  • PipPipPip
  • Advanced Member
  • 1,278 posts
  • LocationUSA

Posted 25 June 2006 - 08:16 PM

Ok cool, thanks.

#11 steviewdr

steviewdr
  • Moderators
  • Advanced Member
  • 1,364 posts
  • LocationIreland

Posted 25 June 2006 - 09:40 PM

At 800x600 your portfolio page is not user friendly - with two scroll bars.
I would prefer you to make the webpage longer rather than putting a scroll on a small div.

Overall - there are no problems/bugs with it.

Are you going to allow something for people who have javascript disabled?

-steve


#12 moberemk

moberemk
  • Members
  • PipPipPip
  • Advanced Member
  • 695 posts

Posted 26 June 2006 - 01:13 PM

That's true. For a CSS-based layout, this still shows much of it's table-based origins. You really should get rid of all the extra images you have floating everywhere where you could just create it in CSS. Like in you navigation-that could just be som CSS blocks.
In addition, your document doesn't have a very good semantic value to it. Try looking at your page without the linked CSS enabled, and see what you think of it then.
Disclaimer: No matter how harsh I may be, I'm always IMO only.

#13 cmgmyr

cmgmyr
  • Members
  • PipPipPip
  • Advanced Member
  • 1,278 posts
  • LocationUSA

Posted 26 June 2006 - 01:39 PM

I will work on the navigation more and try and make it all CSS.

I took off the style sheet in FF, what are some ways that I can make it look better when doing this?

#14 moberemk

moberemk
  • Members
  • PipPipPip
  • Advanced Member
  • 695 posts

Posted 26 June 2006 - 02:38 PM

Give it a document outline. For example, use an image replacement technique in your header to create that image, and use a CSS list for your navigation. Also, take out any extra images, like the big solid colour block to the left of your logo.
Disclaimer: No matter how harsh I may be, I'm always IMO only.




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users