Jump to content

First ever website!


dannyluked

Recommended Posts

Hi,

I have been running this website for about six months now. It has no purpose yet apart form helping me practise my PHP coding skills! It is hosted from a free hosting company and I'd just like a few people to take a look and tell me how I could make any improvements

 

http://dannyluked.comze.com

 

PS. I only really use the site to create PHP stuff so I've not yet moved onto more complicated CSS stuff (planning that soon)

Link to comment
Share on other sites

Thanks guys!

The main reason it is so badly coded is that I made the basic HTML in good code a while ago. Since then Ive started learning PHP so codes have been messed with! I am going to finish the forum and then try to tidy it up.

 

PS. Does anyone know why including header/navigation is slowing down my site and what is the best way to do it, Thanks

Link to comment
Share on other sites

It looks pretty good. Your CSS/Javascript/HTML is all over the place, and you should think about organizing it a little better so the page isn't as cluttered.

 

You need to check verify stuff with PHP too. You're register javascript validation works (to make sure they put in all the correct stuff) but if I turn javascript off, I can register with empty data. I can also log in with empty data too, and the login works after I created an account with empty data.

 

You do use mysql_real_escape_string() on your data, which is good. That flash calender is kind of annoying.

 

You also probably want to apply html entities to your comments. I can inject html in there, and can do harmful things to your site

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.