Bug: Empty lines when [quote]ing

[requinix]

Is

this double-space issue I keep hearing about? This last week is the first time I've heard about it, and I don't remember seeing this happen until now (not to say it didn't, I just don't remember).

[benanamen]

Yes, exactly.

[requinix]

So cyberRobot's post is stored as

<blockquote  class="ipsBlockquote" data-author="benanamen" data-cid="1537698" data-time="1474511715">
<div>
<p>Personally, I don't know why the site was "Upgraded". I never had any problems. Only issue I had was the annoying double space when you did a quote.</p>
</div>
</blockquote>
<p> </p>
<p>I personally liked many of the design changes. And was happy to see the [nobbc][code][/code][/nobbc] tag bug go away, as well as the double space issue. Of course, there were many things I would have needed to adjust to and some that I'm still trying to repress.  </p>

The problem is the extra div/p in the quote. But I don't know how it got into that state.

 

How are you quoting people? Are you using quick reply or the full editor or what? Are you using the editor in text or WYSIWYG mode?

[benanamen]

 

At the least, clicking the quote icon in the standard editor

[requinix]

So it looks like it's a rendering problem instead.

<blockquote  class="ipsBlockquote" data-author="benanamen" data-cid="1537698" data-time="1474511715"><br />
<div><br />
<p>Personally, I don't know why the site was "Upgraded". I never had any problems. Only issue I had was the annoying double space when you did a quote.</p>
</div>
</blockquote>
<p> </p>
<p>I personally liked many of the design changes. And was happy to see the [code][/code] tag bug go away, as well as the double space issue. Of course, there were many things I would have needed to adjust to and some that I'm still trying to repress.  <img src='https://forums.phpfreaks.com/public/style_emoticons/default/happy-04.gif' class='bbc_emoticon' alt=':happy-04:' /></p>

Don't know where the
s are coming from. Well, it's probably converting them from newlines, but the places I've seen that can do it don't appear to be responsible. The raw post is using only \n and not \r\n so it isn't that.

<blockquote  class="ipsBlockquote">
<p> </p>
<p>At the least, clicking the quote icon in the standard editor</p>
</blockquote>

That looks like there's actually a blank line in there when you were writing the post.

[requinix]

Found and patched. Please let me know if you notice something broken.

 

@benanamen: Your example really is a blank line in the post. That's not fixed.

[cyberRobot]

Found and patched. Please let me know if you notice something broken.

 

@benanamen: Your example really is a blank line in the post. That's not fixed.

 

Just testing. The above quote came from pushing the Quote button. And then pressing Post.

[cyberRobot]

Just testing. The above quote came from pushing the Quote button. And then pressing Post.

 

Yay! Now Quote, More Reply Options, and Add Reply.

[cyberRobot]

Hmm...that seems to have taken care of the issue for me. Thanks requinix!

[benanamen]

Didnt fix it. There is no blank line before post is submitted.

 

 

Test

Edited September 23, 2016 by benanamen

[cyberRobot]

Hmm...that seems to have taken care of the issue for me. Thanks requinix!

 

Test in Firefox. (Quote and Post)

 

Does the Quote button work for anyone else in Internet Explorer 11? Note that I'm referring to the button in the lower-right corner under a person's post. I don't use IE for much, other than for testing. I don't think I modified the browser with any plugins or anything that would get in the way.

Edited September 23, 2016 by cyberRobot

[cyberRobot]

 

Something important

 

Here's a test for the Quote feature next to the code tags button (<>).

 

Ding, ding, ding. We have a winner.

Edited September 23, 2016 by cyberRobot

[requinix]

How are you using it? When I use that button the editor puts the cursor on a new line inside the quote, but if I click away then the empty line disappears.

[benanamen]

When I click the quote icon there is no new line. It is a single line which is how I would expect for it to remain when I click post, but it adds in a line after clicking post.

 

While we are at it. There is another longstanding problem I have had. There is no way for me to add attachments. I can click my media and select something that I somehow was able to attach at one point in time. I can't add anything new.

Edited September 24, 2016 by benanamen

[kicken]

If you click the quote button, type something, then hit preview you can see what happens. I can anyway.

 

It seems like what happens is when you click quote it for some reason creates an empty <p></p> tag. Since it's empty it takes up no height but after posting / previewing that empty tag becomes <p><br></p> and so now it shows as a blank line.

 

No idea why it creates the empty tag though.

[requinix]

I think the empty tag is being added by CKEditor. I can't find any settings for it in IPB, and I can't simply remove a

 

 

because that's used for blank lines. So fixing that will probably require spelunking into CKEditor.

 

While we are at it. There is another longstanding problem I have had. There is no way for me to add attachments. I can click my media and select something that I somehow was able to attach at one point in time. I can't add anything new.

IPB gives me a way to log in as people. As you, if I go into Coding Help, pick a thread, and go to the full editor, I see the options to attach files. I don't see it when trying to post to this thread. So are you not able to attach files in specific forums? Or at all? Do you see the attachment form?