two column in table in php

[sigmahokies]

Hi everyone,

 

I am trying to create two column in php with for loop. seem it is not really work very good because it is repeating. I need to create one value in each value, not repeat.

 

what I need is in output:

 

| value1 | value2 |

| value3 | value4 |

 

but I made an ouput:

 

| value1 | value2 |

| value1 | value2 |

 

Please forgive me for my english error because it is not my prime language, I am using sign language - American Sign Language.

 

Here my code:

 

 <?php
 
require('require.php');
 
$list = "select FirstName, LastName from Members";
$display = mysqli_query($GaryDB,$list);
 
if(mysqli_num_rows($display)) {
    while($list2 = mysqli_fetch_assoc($display)) {
        for($x = 2; $x < 3; $x++) {
            echo "<tr>";
            for($y = 1; $y < 3; $y++) {
                echo "<td>".$list2['FirstName']." ".$list2['LastName']."</td>";
            }
            echo "</tr>";
        }
    }
}
 

 

Any help will be very appreciate!

 

Thank you so much!

 

Gary Taylor

Edited July 20, 2017 by gizmola
[php] -> [code]

[requinix]

Try a structure more like this:

 

$display = do query
if rows {
	<table>

	$list2 = first row
	do {
		<tr>

		for $x = 1; $x <= number of columns; $x++ {
			<td>
			if $list2 {
				values from $list2
			} else {
				empty cell
			}
			</td>

			$list2 = next row
		}

		</tr>
	} while ($list2);

	</table>
}

[Sepodati]

Are you trying to show

 

| First Name 1 | Last Name 1 |

| First Name 2 | Last Name 2 |

 

or something like 

 

| Person 1 | Person 2 |

| Person 3 | Person 4 |

[ginerjm]

You do realize that the fetch only retrieves one row at a time?  I don't know why you have the loop inside the loop.

 

While ($row = fetch)

{

  echo "<tr>";

  echo "<td>" . $row['firstname']. "</td><td>" . $row['lastname']."</td>";

  echo "</tr>";

}

This would give you the two across rows that you appear to  be asking for.

[sigmahokies]

Sepodati,

 

I am asking for second of your paragraph, like this:

 

| person 1 | Person 2 |

| Person 3 | Person 4 |

 

Now, I am trying other reply who make a suggest to me...

[sigmahokies]

requinix,

 

I tried your script, but it doesn't work, it is "infinite: loop, I have to stop this loop.

 

anyone can make a suggest?

[requinix]

fourth this week I think

 

What is your code?

[Psycho]

//Set number of columns for the output

$columns = 2;

 

require('require.php');

 

$query = "SELECT FirstName, LastName FROM Members";

$result = mysqli_query($GaryDB, $query);

 

if(mysqli_num_rows($result))

{

    //dump records into array

    $records = array();

    while($row = mysqli_fetch_assoc($result))

    {

        $records[] = $row;

    }

    //Chunk the array by column count and create output

    $output = '';

    foreach(array_chunk($records, $columns) as $row)

    {

        $output .= "<tr>\n";

        foreach($row as $record)

        {

            $output .= "<td>{$row['FirstName']} {$row['LastName']}</td>\n";

        }

        $output .= "</tr>\n";

    }

}

Edited July 20, 2017 by cyberRobot
removed extra equal signs (eg. $output = .= "<tr>\n";)

[Sepodati]

Dumping everything into an array and then looping through it seems like a waste of time and resources to me. 

 

I'd do it like this. This is with an array, but it gives you the concept. 

 

<?php
 
$data = array('Person 0','Person 1','Person 2','Person 3','Person 4','Person 5','Person 6');
 
$count = 0;
echo "<table border=\"1\">\n";
foreach($data as $p) {
  if($count % 2 == 0) { echo "<tr>\n"; }
  echo "<td>{$p}</td>\n";
  if($count % 2 == 1) { echo "</tr>\n"; }
  $count++;
}
if($count % 2 == 1) { echo "<td> </td>\n</tr>\n"; }
echo '</table>';
?>

Output:

<table border="1">
 <tr>
  <td>Person 0</td>
  <td>Person 1</td>
 </tr>
 <tr>
  <td>Person 2</td>
  <td>Person 3</td>
 </tr>
 <tr>
  <td>Person 4</td>
  <td>Person 5</td>
 </tr>
 <tr>
  <td>Person 6</td>
  <td> </td>
 </tr>
</table>

Essentially, you keep a counter as you loop through your results. On EVEN increments through the loop, you start a table row and on ODD increments, you end the table row.

 

There's an extra check at the end to add an empty cell and close out the table row if the overall number of results were ODD.

Edited July 19, 2017 by Sepodati

[Jacques1]

Dumping everything into an array and then looping through it seems like a waste of time and resources to me.

 

Do you really think that saving a few CPU cycles and bytes of RAM is the OP's biggest concern?

[Sepodati]

Do you really think that saving a few CPU cycles and bytes of RAM is the OP's biggest concern?

Probably not, but why do it if you don't have to?

[Psycho]

Dumping everything into an array and then looping through it seems like a waste of time and resources to me. 

 

I was going to do it the way you showed - which is how I always used to do it. But, there is a very good reason I do not to do it that way (most of the time). That way requires multiple if() statements to determine the beginning of a row, the end of a row and to determine if the loop ended without properly closing the row. With a relatively simple output such as this the logic for those statements isn't too complex. With a more complicated output the logic can become unwieldy. E.g. if you dealing with 'rows' that are created with multiple levels of DIVs, the logic for closing a row and handling the last row when there are uneven number of elements. By using array_chunk() it takes all the complexity out of the problem. Just loop through the chunks with a single process to start a row, output the data and close the row - whether it is a table row or a more complicated structure.

 

Plus, without bench-marking you have no idea which is more efficient. The if() statements could be more resource intensive than the other method.

[Sepodati]

I agree totally and understand your reasoning. AS with everything, "it depends" is the right answer.

 

I didn't mean for my response to come across as negative as it appears to.

[cyberRobot]

Here's a slightly different version of Psycho's solution:

<?php
//Set number of columns for the output
$columns = 2;
 
require('require.php');
 
$query = "SELECT FirstName, LastName FROM Members";
$result = mysqli_query($GaryDB, $query);
 
//dump records into array
$records = array();
while($row = mysqli_fetch_assoc($result)) {
    $records[] = "<td>{$row['FirstName']} {$row['LastName']}</td>";
}
 
//Chunk the array by column count and create output
$output = '';
if(!empty($records)) {
    foreach(array_chunk($records, $columns) as $row) {
        $output .= "<tr>" . implode($row) . "</tr>\n";
    }
}
?>

[sigmahokies]

Sepodati and Psycho,

I found a way to solution my problem. Hey, Psycho, I used your method of array at top of script of php, then I used Sepodati's body of foreach, it works! Let me show you a code:

 

<?php
 
require('require.php');
$list = "select FirstName, LastName from Members";
$display = mysqli_query($GaryDB,$list);
 
$record = array();
 
$count = 0;
if(mysqli_num_rows($display)) {
while($row = mysqli_fetch_assoc($display)) {
$record[] = $row;
}
foreach($record as $z) {
if($count % 2 == 0) {
echo "<tr>";
}
echo "<td>".$z['FirstName']." ".$z['LastName']."</td>";
if($count % 2 == 1) {
echo "</tr>";
}
$count++;
}
if($count % 2 == 1) {
echo "<td> </td></tr>";
}
}
 
 ?>

Edited July 29, 2017 by sigmahokies

[Jacques1]

This combination doesn't make any sense, because now you have all the bad parts: The inefficiency of Psycho's solution and the complexity of Sepodati's solution.

 

Don't just blindly copy and paste code. Try to actually understand what it does. In this particular case, I'd go with Psycho's approach, because it's more straightforward.