Jump to content


  • Posts

  • Joined

  • Last visited

Posts posted by moberemk

  1. [QUOTE]IDs have a higher specificity rating, making them overrulling over classes. So when you give something a class and an ID, the ID's rules come first.[/QUOTE]
    Also, Javascript can only call ID's, unless you use the Prototype Library's dollar function.
  2. Just a quick thing before I sleep; the site takes a long time to load fully with all the images, and you should really look into using more CSS. And get rid of all those <font> tags; replace them with classed <span>s, as well as getting rid of all the inline styles and replacing them with an external stylesheet.
  3. Yes, except that is a deprecated attribute. Your HTML is filled with them, using style attributes where you probably should start switching to CSS. It will work without any changes, but it's obsolete, and generates a lot of extra markup. All those font tags you use could be replaced with a <span> tag with a class, for example. Rather then specifying on a by-tag basis what you want it to look like, use more general CSS classes. It makes life a lot easier.
  4. If you want it to stretch, all you would need to do is make it a CSS background image. However, you don't use CSS, you use HTML. And if you want to have less deprecated code, you should probably get rid of the <center> and <font> tags and instead use CSS for that stuff.
  5. IDs have a higher specificity rating, making them overrulling over classes. So when you give something a class and an ID, the ID's rules come first.
  6. Well, for one thing, add some spacing. Everything is really crammed together. In addition to that, your side boxes are just floating, with no border or definition, and also probably to the border of the page itself. As it stands, the site is really disjointed and hard-to-read, and those two weird grey bars you have everywhere really don't add anything. I'll bet that your site is based on your forum skin, right (speaking of which, shouldn't there be some kind of notification outside of the code that said that the theme isn't your design)? Not to mention that your site doesn't resize AT ALL. You can see it fine at 1024*768, but nothing lower (even though there are still plenty of people who prefer the size of 800*600). Your topic images are also fairly ugly. And what's with this?
    On the code side, you have over [url=http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fwww.pcritics.com%2F]135 validation errors[/url], half your code is deprecated elements since HTML4.0, and you've got a ton of javascript commands and you've taken a 2px image and stretched it to 936px.
    In summary, your site is an IPB skin clone that fails to capture the essence of the original, with some fairly inept HTML code, deprecated elements for everything, and a few reviews that aren't organized outside of alphabetically. And once you get more reviews, won't that page get a little long?
  7. Aah. Okay, that explains that. Thanks for clearing that up for me.
    Now the only thing I don't get is why every time I post, it brings me back to the parent forum. Couldn't that maybe become some sort of option for those of us whom it merely annoys? It's a useful feature for some, but because I always browse the forum in tabs, I just don't need it around, and I'm used to being able to look over my post and make sure that I said what I meant.
  8. This is what is termed as "Programmer Art", or something created by someone who can outcode anyone but who probably shouldn't touch the graphics. It's big, it's red, it generates [url=http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fwww.knightsdivine.net%2F]bad HTML[/url] and [url=http://jigsaw.w3.org/css-validator/validator?profile=css2&warning=2&uri=http%3A%2F%2Fwww.knightsdivine.net%2F]CSS[/url], and then there's this piece here:
    [code]<link href=css.css rel=stylesheet type=text/css>
    <link rel="icon" href="http://kd.madur.net/little.jpg">
    <link rel="shortcut icon" href="http://kd.madur.net/little.jpg">
    <META NAME="keywords" CONTENT="Knights Divine, kd, bearruler, MMORPG, online game, game, free, army, medieval, fun, recruit, master, apprentice, rpg, php, mysql, nerd, geek">
    <META NAME="description" CONTENT="Knights Divine is an MMORPG that lets players build their own army, attack/spy on/steal from other players, buy weapons, upgrade, and train followers.">
    <META NAME="author" CONTENT="bearruler, Knights Divine">

    <title>Knights Divine</title>

    Aren't LINK and META tags supposed to go inside the <head> element? You don't have a DOCTYPE either, you have a beveled circle as your logo (that technique went out when it came in) and you've got more tables then I even want to think about. In summary, get someone to help you redesign the entire HTML output from the ground up, and delete everything you have relating to style.
    Okay, a little harsh, but that is all IMO.
  9. It looks cool, but it may be the most pointless use of tables I've ever seen. You should really take those out. It would also probably help if you had a DOCTYPE at the top too.
  10. Give it a document outline. For example, use an image replacement technique in your header to create that image, and use a CSS list for your navigation. Also, take out any extra images, like the big solid colour block to the left of your logo.
  11. That's true. For a CSS-based layout, this still shows much of it's table-based origins. You really should get rid of all the extra images you have floating everywhere where you could just create it in CSS. Like in you navigation-that could just be som CSS blocks.
    In addition, your document doesn't have a very good semantic value to it. Try looking at your page without the linked CSS enabled, and see what you think of it then.
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.